-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Generate versions HTML directly #13414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could not assign reviewer from: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. 2 questions remaining.
I also want to give @xFrednet a chance to sanity check this.
f64e0ab
to
d2305ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Giving xFrednet a bit more time to take a look.
Looks good to me as well, nice update :D Roses are red, The lint page, |
@bors r- |
I got too swept up in the poem xD Now one more try: Roses are red, The lint page, |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Generates the page at https://rust-lang.github.io/rust-clippy/ directly rather than creating a JSON file to load
Also fixes #13413
r? @flip1995
changelog: none