Skip to content

Generate versions HTML directly #13414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Alexendoo
Copy link
Member

Generates the page at https://rust-lang.github.io/rust-clippy/ directly rather than creating a JSON file to load

Also fixes #13413

r? @flip1995

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

Could not assign reviewer from: flip1995.
User(s) flip1995 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 18, 2024
@flip1995
Copy link
Member

Forgot to remove my name from the vacation list: #13415

r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned xFrednet Sep 18, 2024
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. 2 questions remaining.

I also want to give @xFrednet a chance to sanity check this.

@Alexendoo Alexendoo force-pushed the generate-versions-html branch from f64e0ab to d2305ff Compare September 18, 2024 18:52
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Giving xFrednet a bit more time to take a look.

@xFrednet xFrednet self-assigned this Sep 19, 2024
@xFrednet
Copy link
Member

Looks good to me as well, nice update :D


Roses are red,
Violets are blue,
@flip1995 approved,
Now bors, you do you

The lint page,
now static in nature,
loads quick,
and safer

@bors
Copy link
Contributor

bors commented Sep 19, 2024

📌 Commit d2305ff has been approved by xFrednet

It is now in the queue for this repository.

@xFrednet
Copy link
Member

@bors r-

@xFrednet
Copy link
Member

I got too swept up in the poem xD

Now one more try:

Roses are red,
Violets are blue,
@flip1995 approved,
Now bors, you do you

The lint page,
now static in nature,
loads quick,
and safer

@bors
Copy link
Contributor

bors commented Sep 19, 2024

📌 Commit d2305ff has been approved by flip1995,xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 19, 2024

⌛ Testing commit d2305ff with merge 2e5b680...

@bors
Copy link
Contributor

bors commented Sep 19, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995,xFrednet
Pushing 2e5b680 to master...

@bors bors merged commit 2e5b680 into rust-lang:master Sep 19, 2024
5 checks passed
@Alexendoo Alexendoo deleted the generate-versions-html branch September 19, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fork-me image is broken
5 participants