print git commit hash and commit date in version output #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiaskrgr
force-pushed
the
clippy_git_version
branch
from
b078818 to
6a72ca0
Compare
oli-obk
reviewed
Sep 6, 2018
matthiaskrgr
force-pushed
the
clippy_git_version
branch
from
6a72ca0 to
46c782d
Compare
oli-obk
suggested changes
Sep 6, 2018
rustc_tools_util/src/lib.rs
Outdated
| } | ||
|
|
||
| // https://internals.rust-lang.org/t/macro-trait-implementation/5492 | ||
| impl VersionInfo { |
There was a problem hiding this comment.
isn't this function and the Default impl essentially always wrong? And also unused, so it could be removed entirely
There was a problem hiding this comment.
I added the Default because of #[warn(clippy::new_without_default_derive)] on by default 😆
I'll remove the ::new() and ::default()
matthiaskrgr
force-pushed
the
clippy_git_version
branch
from
46c782d to
f5885f2
Compare
clippy 0.0.212 (964fcbe0 2018-09-06)
matthiaskrgr
force-pushed
the
clippy_git_version
branch
from
f5885f2 to
fa11aad
Compare
oli-obk
approved these changes
Sep 6, 2018
|
this will be super helpful 🎉 |
|
@matthiaskrgr If you're interested: I think the rls people would be very happy to reuse the tools-util crate instead of having a copy of that code in their own codebase |
|
@oli-obk yeah, that was my going to be my next step :D |
bors-voyager bot
added a commit
to rust-lang/rls
that referenced
this pull request
Sep 22, 2018
1051: fix build and use clippys rustc_tools_util to generate version information r=Xanewok a=matthiaskrgr See rust-lang/rust-clippy#3137 (comment) Co-authored-by: Matthias Krüger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clippy 0.0.212 (964fcbe0 2018-09-06)Fixes #3015