Fix 3145 #3146
Merged
Fix 3145 #3146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Sep 7, 2018
tests/compile-fail/issue-3145.rs
Outdated
| @@ -0,0 +1,3 @@ | |||
| fn main() { | |||
| println!("{}" a); //~ERROR expected token: `,` | |||
There was a problem hiding this comment.
just make it a ui test. Rustc is moving away from compile-fail, there's no guarantee these are kept around.
oli-obk
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3145
This error originates on this assert:
https://github.com/rust-lang-nursery/rust-clippy/blob/63a46b1e1a9a4cc3d78e1cf7a628421051c21167/clippy_lints/src/write.rs#L286-L289
The
check_ttsfunction gets the arguments of the macro call as aThinTokenStream:The thought behind this assertion is that if no
Commais found after a parsedexprthe parser has reached the end of theThinTokenStream, becauseexprs need to be seperated by aComma. But with a syntax error likeprintln!("{}" a);this is not the case. Removing the assertion is a simple fix, that shouldn't break anything.r? @oli-obk