Suggest .as_ref()? instead of ? in certain circumstances.

[fuerstenau]

No description provided.

[fuerstenau]

It works^{TM} but obviously should be sanity checked by someone who knows what they are doing. I'm not even capable of not confirming the pull request by some accidental button mashing before writing a description. (=

[oli-obk]

lgtm.

r=me with rustfmt run

[ghost]

This change contains a bug. When the if expression contains an else branch but that doesn't match subject.

#![deny(clippy::all)]

pub fn func(x: Option<u32>) -> Option<u32> {

    let _ = if x.is_none() {
        return None;
    } else {
        //x
        Some(0)
    };

    Some(0)
}

fn main() {
}

error: this block may be rewritten with the `?` operator
  --> src/main.rs:12:13
   |
12 |       let _ = if x.is_none() {
   |  _____________^
13 | |         return None;
14 | |     } else {
15 | |         //x
16 | |         Some(0)
17 | |     };
   | |_____^ help: replace_it_with

[fuerstenau]

Well the stupid “let's see if this lint should trigger but print out something in any case” bug should be fixed and even includes a test now to make it a bit harder to repeat my mistake.

The commata have been reinserted by hand.

[fuerstenau]

@oli-obk GitHub still shows this as you having requested changes but it does not tell me which changes that should be. Could you either spell out the changes for me or tell me where to look them up?

[oli-obk]

It was just about the formatting failures. So everything is good now

[oli-obk]

@bors r+

[bors]

📌 Commit 8be7050 has been approved by oli-obk

[bors]

⌛ Testing commit 8be7050 with merge 3c4abb5...

[fuerstenau]

That's what I had assumed based on your rather cryptic comment but after a week of trying to confirm my hypothesis without finding a way to do so I elected to ask you about it.

[oli-obk]

I am very sorry about that. I should write my comments out. I'll do my best to do that in the future.

Please never hesitate to ask for clarification or anything else for that matter.

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 3c4abb5 to master...