Skip to content

use_self for tuple structs #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 30, 2018
Merged

use_self for tuple structs #3588

merged 4 commits into from
Dec 30, 2018

Conversation

detrumi
Copy link
Member

@detrumi detrumi commented Dec 27, 2018

Fixes #3498

@detrumi detrumi changed the title use_self for tuple structs use_self for tuple structs Dec 27, 2018
oli-obk
oli-obk reviewed Dec 28, 2018
View reviewed changes
@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Dec 28, 2018
@detrumi detrumi force-pushed the tuple_struct_use_self branch 2 times, most recently from b897181 to ae5c947 Compare December 28, 2018 12:44
@flip1995 flip1995 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 28, 2018
@phansch phansch closed this Dec 28, 2018
@phansch phansch reopened this Dec 28, 2018
@bors
Copy link
Contributor

bors commented Dec 28, 2018

☔ The latest upstream changes (presumably #3587) made this pull request unmergeable. Please resolve the merge conflicts.

@detrumi detrumi force-pushed the tuple_struct_use_self branch from ae5c947 to 76ef082 Compare December 28, 2018 19:35
@bors
Copy link
Contributor

bors commented Dec 29, 2018

☔ The latest upstream changes (presumably #3596) made this pull request unmergeable. Please resolve the merge conflicts.

@detrumi detrumi force-pushed the tuple_struct_use_self branch from f50c91e to 259ec2d Compare December 30, 2018 07:24
@phansch phansch closed this Dec 30, 2018
@phansch phansch reopened this Dec 30, 2018
@phansch
Copy link
Member

phansch commented Dec 30, 2018

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Dec 30, 2018

📌 Commit 259ec2d has been approved by phansch

@bors
Copy link
Contributor

bors commented Dec 30, 2018

⌛ Testing commit 259ec2d with merge 735607c...

bors added a commit that referenced this pull request Dec 30, 2018
@bors
Auto merge of #3588 - detrumi:tuple_struct_use_self, r=phansch
735607c 
`use_self` for tuple structs

Fixes #3498
@bors
Copy link
Contributor

bors commented Dec 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: phansch
Pushing 735607c to master...

@bors bors merged commit 259ec2d into rust-lang:master Dec 30, 2018
@detrumi detrumi deleted the tuple_struct_use_self branch December 30, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@detrumi @bors @phansch @oli-obk @flip1995