Only trigger infinite_iter lint for infinitely allocating collect() calls
#3607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detrumi
force-pushed
the
limit_infinite_iter_to_known_types
branch
from
4515fc7 to
66acaa9
Compare
detrumi
force-pushed
the
limit_infinite_iter_to_known_types
branch
from
66acaa9 to
f38fb56
Compare
flip1995
added
the
S-waiting-on-review
|
@bors r+ thanks! |
|
📌 Commit f38fb56 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 2, 2019
…hansch Only trigger `infinite_iter` lint for infinitely allocating `collect()` calls Fixes #3538 ~Oh, I guess this should actually check other methods like `count` as well, not only `collect()`.~ Never mind, `collect` is the only of these functions that allocates a data structure.
phansch
removed
the
S-waiting-on-review
|
💥 Test timed out |
|
@bors retry (AppVeyor timeout) |
bors
added a commit
that referenced
this pull request
Jan 3, 2019
…hansch Only trigger `infinite_iter` lint for infinitely allocating `collect()` calls Fixes #3538 ~Oh, I guess this should actually check other methods like `count` as well, not only `collect()`.~ Never mind, `collect` is the only of these functions that allocates a data structure.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3538
Oh, I guess this should actually check other methods likecountas well, not onlycollect().Never mind,
collectis the only of these functions that allocates a data structure.