Restrict use_self on nested items
#3640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detrumi
force-pushed
the
nested_use_self
branch
from
f99f785 to
ff191a8
Compare
flip1995
requested changes
Jan 7, 2019
flip1995
approved these changes
Jan 7, 2019
|
@bors r+ Thanks! |
|
@bors r=flip1995 |
|
📌 Commit 466cd07 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 7, 2019
Restrict `use_self` on nested items Fixes #3637 Fixes #3463 These changes make it so that nested items aren't visited any more by the `use_self` lint. I think visiting nested items should be possible (so that it uses a different `item_path` for the nested item), but I'm not sure whether it's viable and what the best approach would be. - Can `item_path` be changed to a new `Self` path before visiting the item, and then changing it back afterwards? - Alternatively, could a new visitor be created, re-using `check_trait_method_impl_decl`?
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Mar 12, 2019
Fix `use_self` false positive on nested functions Related to #3640 The current `use_self` warns the following code. ```rust #![warn(clippy::use_self)] struct Foo {} impl Foo { fn bar() { fn baz() -> Foo { //^ warning: unnecessary structure name repetition Foo {} //^ warning: unnecessary structure name repetition } } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3637
Fixes #3463
These changes make it so that nested items aren't visited any more by the
use_selflint.I think visiting nested items should be possible (so that it uses a different
item_pathfor the nested item), but I'm not sure whether it's viable and what the best approach would be.item_pathbe changed to a newSelfpath before visiting the item, and then changing it back afterwards?check_trait_method_impl_decl?