Skip to content

Add doc(include = ...) detection to missing_docs_in_private_items #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Add doc(include = ...) detection to missing_docs_in_private_items #3883

merged 3 commits into from
Mar 15, 2019

Conversation

daxpedda
Copy link
Contributor

The whole missing documentation in crate part doesn't have any tests. If I should add test cases tell me.

Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a test would be really appreciated to prevent future regressions =)

edit: woops, I didn't mean to click on 'Request changes', just wanted to leave a comment.

@phansch phansch requested review from phansch and removed request for phansch March 14, 2019 17:57
@daxpedda
Copy link
Contributor Author

Done.

@phansch
Copy link
Member

phansch commented Mar 15, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Mar 15, 2019

📌 Commit 9061fd3 has been approved by phansch

@bors
Copy link
Contributor

bors commented Mar 15, 2019

⌛ Testing commit 9061fd3 with merge e780641...

bors added a commit that referenced this pull request Mar 15, 2019
Add `doc(include = ...)` detection to `missing_docs_in_private_items`

The whole `missing documentation in crate` part doesn't have any tests. If I should add test cases tell me.
@bors
Copy link
Contributor

bors commented Mar 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing e780641 to master...

@bors bors merged commit 9061fd3 into rust-lang:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants