Skip to content

Check PRs for changelog entry in the body #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 25, 2019

changelog: none

@flip1995 flip1995 closed this Apr 25, 2019
@flip1995 flip1995 reopened this Apr 25, 2019
@flip1995
Copy link
Member Author

flip1995 commented Apr 25, 2019

Hmm. The MacOS fails because of the rate limit of the GitHub API.

Can we somehow get an API key or do we need to find another way to check for this? cc @Manishearth

@oli-obk
Copy link
Contributor

oli-obk commented Apr 25, 2019

We could just run this in a single instance (e.g. linux)

@flip1995
Copy link
Member Author

Even then we only have 60 requests per hour per IP address. And since we're using some Travis IP address I think this is not something we want to rely on.

@flip1995
Copy link
Member Author

Linux build also failed for the same reason:
https://travis-ci.com/rust-lang/rust-clippy/jobs/195597674#L501-L503

@oli-obk
Copy link
Contributor

oli-obk commented Apr 25, 2019

60 per hour isn't great indeed. Is an API key the same thing as a deploy key? I can add one in that case.

@flip1995
Copy link
Member Author

I just found out, that this could be done with personal access tokens: https://developer.github.com/v3/auth/#via-oauth-tokens

I can add one of these by myself 👍

@flip1995
Copy link
Member Author

That didn't work. I continue with this later.

@flip1995
Copy link
Member Author

Oh no: https://travis-ci.com/rust-lang/rust-clippy/jobs/195669235#L413-L414

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

@flip1995
Copy link
Member Author

flip1995 commented May 3, 2019

Closing this, since

  1. Secret env vars don't work on PRs from forks (obv security reasons)
  2. Pulling the PR body through the github API doesn't work, since we need some kind of API token. And using this API token is (AFAIK) only possible through secrets.

@flip1995 flip1995 closed this May 3, 2019
bors added a commit that referenced this pull request Jun 15, 2019
Check for changelog entry in PR bodies

cc #4031 but now on the auto and try branches. (#3955 (comment))
bors added a commit that referenced this pull request Jun 15, 2019
Check for changelog entry in PR bodies

cc #4031 but now on the auto and try branches. (#3955 (comment))
bors added a commit that referenced this pull request Jun 15, 2019
Check for changelog entry in PR bodies

cc #4031 but now on the auto and try branches. (#3955 (comment))
bors added a commit that referenced this pull request Jun 15, 2019
Check for changelog entry in PR bodies

cc #4031 but now on the auto and try branches. (#3955 (comment))
bors added a commit that referenced this pull request Jun 15, 2019
Check for changelog entry in PR bodies

cc #4031 but now on the auto and try branches. (#3955 (comment))

changelog: none
bors added a commit that referenced this pull request Jul 15, 2019
Check for changelog entry in PR bodies

cc #4031 but now on the auto and try branches. (#3955 (comment))

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants