-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Check PRs for changelog entry in the body #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a1e46a
to
85c75cb
Compare
Hmm. The MacOS fails because of the rate limit of the GitHub API. Can we somehow get an API key or do we need to find another way to check for this? cc @Manishearth |
We could just run this in a single instance (e.g. linux) |
Even then we only have 60 requests per hour per IP address. And since we're using some Travis IP address I think this is not something we want to rely on. |
Linux build also failed for the same reason: |
60 per hour isn't great indeed. Is an API key the same thing as a deploy key? I can add one in that case. |
I just found out, that this could be done with personal access tokens: https://developer.github.com/v3/auth/#via-oauth-tokens I can add one of these by myself 👍 |
That didn't work. I continue with this later. |
08ab980
to
ffb308a
Compare
Oh no: https://travis-ci.com/rust-lang/rust-clippy/jobs/195669235#L413-L414
|
Closing this, since
|
Check for changelog entry in PR bodies cc #4031 but now on the auto and try branches. (#3955 (comment))
Check for changelog entry in PR bodies cc #4031 but now on the auto and try branches. (#3955 (comment))
Check for changelog entry in PR bodies cc #4031 but now on the auto and try branches. (#3955 (comment))
Check for changelog entry in PR bodies cc #4031 but now on the auto and try branches. (#3955 (comment))
Check for changelog entry in PR bodies cc #4031 but now on the auto and try branches. (#3955 (comment)) changelog: none
Check for changelog entry in PR bodies cc #4031 but now on the auto and try branches. (#3955 (comment)) changelog: none
changelog: none