a few minor cleanups #4946
Merged
a few minor cleanups #4946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
approved these changes
Dec 23, 2019
|
r=me once travis passes @bors delegate+ |
|
✌️ @lzutao can now approve this pull request |
flip1995
reviewed
Dec 23, 2019
tesuji
force-pushed
the
take
branch
3 times, most recently
from
8f54ebc to
3e84ffe
Compare
|
@bors r=flip1995 |
|
📌 Commit 3e84ffe has been approved by |
bors
added a commit
that referenced
this pull request
Dec 23, 2019
a few minor cleanups changelog: none
|
@bors r- |
|
💔 Test failed - checks-travis |
* ToString and AsRef are in prelude, no need to import them
|
@bors r=flip1995 |
|
📌 Commit f5b8964 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 23, 2019
a few minor cleanups changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none