Skip to content

Improve lint message in to_string_in_display #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

giraffate
Copy link
Contributor

This is a follow-up of #5831.

changelog: none

@rust-highfive
Copy link

r? @yaahc

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 19, 2020
Copy link
Member

@yaahc yaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for taking the time to clean this up.

@bors r+

@matthiaskrgr
Copy link
Member

@bors r=yaahc

there's a bug with bors where the command is lost when approve a pr with the same message :/

@bors
Copy link
Contributor

bors commented Aug 22, 2020

📌 Commit 902b282 has been approved by yaahc

@bors
Copy link
Contributor

bors commented Aug 22, 2020

⌛ Testing commit 902b282 with merge b57ef14...

@bors
Copy link
Contributor

bors commented Aug 22, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: yaahc
Pushing b57ef14 to master...

@bors bors merged commit b57ef14 into rust-lang:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants