-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix FP in print_stdout
#6079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix FP in print_stdout
#6079
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2892a2b
Fix FP in `print_stdout`
giraffate 5b484b4
Fix the detection of build scripts
giraffate 83294f8
Some small fixes
giraffate 71b6d54
Add build script but does not work in the dogfood test
giraffate 1214a85
Add missing attr to clippy_workspace_tests/build.rs
ebroto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#![deny(clippy::print_stdout)] | ||
|
||
fn main() { | ||
// Test for #6041 | ||
println!("Hello"); | ||
print!("Hello"); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// compile-flags: --crate-name=build_script_build | ||
|
||
#![warn(clippy::print_stdout)] | ||
|
||
fn main() { | ||
// Fix #6041 | ||
// | ||
// The `print_stdout` lint shouldn't emit in `build.rs` | ||
// as these methods are used for the build script. | ||
println!("Hello"); | ||
print!("Hello"); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.