Skip to content

cloned_instead_of_copied MSRV #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Conversation

camsteffen
Copy link
Contributor

changelog: none
(since the lint is still new)

Fixes #7127

r? @Manishearth

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 25, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2021

📌 Commit 3f5be5e has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Apr 25, 2021

⌛ Testing commit 3f5be5e with merge c4e2d36...

@bors
Copy link
Contributor

bors commented Apr 25, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing c4e2d36 to master...

@bors bors merged commit c4e2d36 into rust-lang:master Apr 25, 2021
@flip1995
Copy link
Member

When adding a MSRV, you should also add a test for it and add the lint name in the conf.rs file to the configuration option. Every step is documented here: https://github.com/rust-lang/rust-clippy/blob/master/doc/adding_lints.md#specifying-the-lints-minimum-supported-rust-version-msrv

@camsteffen
Copy link
Contributor Author

Thanks, I'll do that in a bit.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 27, 2021
…ip1995

Update Clippy

Out of cycle sync: I want to get rust-lang/rust-clippy#7129 into beta that is branched next week.

This sync only adds one new feature in efc4c6c, which looks fine to me. Otherwise it only contains bug fixes and/or restricts lints further.

r? `@Manishearth`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloned_instead_of_copied fails to respect msrv
5 participants