Use node v12.x in CI #7529
Merged
Use node v12.x in CI #7529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
How did you catch that one? @bors r+ |
|
📌 Commit f4ea50b has been approved by |
bors
added a commit
that referenced
this pull request
Aug 4, 2021
Use node v12.x in CI In #7528 (comment), remark-cli version has been updated recently and it requires to use ESM module: https://github.com/remarkjs/remark/releases/tag/14.0.0. Node version in CI was v10.24.1, it seems to be old. changelog: none
|
💔 Test failed - checks-action_remark_test |
|
Syntax errors in #7528 (comment) have been resolved, but new warnings like below happen. I don't know why these happen suddenly, but I addresses it anyway. |
I checked error logs, npm page and changelog in remark one by one :) |
|
@bors r=flip1995,llogiq |
|
📌 Commit 827f661 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
joshrotenberg
added a commit
to joshrotenberg/rust-clippy
that referenced
this pull request
Aug 5, 2021
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Jan 21, 2022
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Jan 27, 2022
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 5, 2022
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7528 (comment), remark-cli version has been updated recently and it requires to use ESM module: https://github.com/remarkjs/remark/releases/tag/14.0.0. Node version in CI was v10.24.1, it seems to be old.
changelog: none