This repository was archived by the owner on Apr 5, 2024. It is now read-only.
More flexible rule around adding public fields to struct with private fields #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
more-flexible-rule
branch
from
248b133 to
e27b6a3
Compare
|
cc @JohnTitor |
GuillaumeGomez
changed the title
GuillaumeGomez
force-pushed
the
more-flexible-rule
branch
from
e27b6a3 to
a3d2d7c
Compare
JohnTitor
approved these changes
Oct 19, 2021
|
Thanks! @bors r+ |
|
📌 Commit a3d2d7c has been approved by |
|
☀️ Test successful - checks-actions |
|
@JohnTitor Can you make a release whenever you can please? I'll update the libc PR afterwards to update the dependency version. |
|
Released 0.1.48, it can be used with |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from rust-lang/libc#2451.
Before this PR, the
kinfo_procstruct only had one field which was private. I added the missing fields and made them all public. It doesn't seem to be a semver breaking change as the code using this struct previously will still work exactly the same.