Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Fix compilation #92

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix compilation #92

merged 1 commit into from
Feb 18, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Feb 13, 2019

Compilation is broken on nightly

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 13, 2019

travis-ci is still disabled =/ @rust-dev-tools ping

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 18, 2019

ping @ibabushkin

@ibabushkin ibabushkin merged commit 3f703b6 into rust-lang:master Feb 18, 2019
@ibabushkin
Copy link
Contributor

LGTM, sorry for the latency.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 18, 2019

Don't worry, its that time of the year where people have exams. Good luck if you have any.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Feb 19, 2019

@ibabushkin i'm trying to use this to verify that the libc crate does not introduce any backwards incompatible changes "by mistake" (we do some times do this, but it should be an explicit decision to do so, and not due to oversight).

For this I need rust-semverver to essentially always compile properly with the latest nightly, and if things break, to be fixed ASAP. I don't know what would be the best way to achieve that. cc @rust-dev-tools

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants