Skip to content

Commit b383aec

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 04ef4d1 commit b383aec

File tree

1 file changed

+163
-0
lines changed

1 file changed

+163
-0
lines changed

‎triage/2023-10-18.md

Lines changed: 163 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,163 @@
1+
# 2023-10-18 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [84d44dd1d8ec1e98fff94272ba4f96b2a1f044ca..b9832e72c9223f4e96049aa5911effd258b92591](https://perf.rust-lang.org/?start=84d44dd1d8ec1e98fff94272ba4f96b2a1f044ca&end=b9832e72c9223f4e96049aa5911effd258b92591&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 3.0% | [0.3%, 12.2%] | 7 |
13+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.3%, 1.2%] | 15 |
14+
| Improvements ✅ <br /> (primary) | -1.1% | [-17.9%, -0.2%] | 131 |
15+
| Improvements ✅ <br /> (secondary) | -2.4% | [-39.6%, -0.2%] | 121 |
16+
| All ❌✅ (primary) | -0.9% | [-17.9%, 12.2%] | 138 |
17+
18+
19+
4 Regressions, 1 Improvements, 4 Mixed; ??? of them in rollups
20+
84 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 7 pull requests [#116605](https://github.com/rust-lang/rust/pull/116605) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5b88d659f8c2428536589d4bd36b9099d53a6815&end=c30b28bdc17f1da73515afa0886f0d4f55c76e1f&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.6%] | 7 |
29+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.4%] | 3 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.4% | [0.2%, 0.6%] | 7 |
33+
34+
35+
Optimize `librustc_driver.so` with BOLT [#116352](https://github.com/rust-lang/rust/pull/116352) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ee8c9d3c34719a129f280cd91ba5d324017bb02b&end=c543b6f3516767150af84d94c14a27b19d4b0291&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:-----:|:--------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 2.3% | [0.2%, 5.7%] | 10 |
40+
| Regressions ❌ <br /> (secondary) | 1.9% | [0.3%, 5.0%] | 60 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 4 |
43+
| All ❌✅ (primary) | 2.3% | [0.2%, 5.7%] | 10 |
44+
45+
46+
Rollup of 3 pull requests [#116742](https://github.com/rust-lang/rust/pull/116742) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c543b6f3516767150af84d94c14a27b19d4b0291&end=e292fec36880f48101bda4054be37097312e73c0&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.4%] | 3 |
51+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.4%] | 3 |
55+
56+
57+
don't UB on dangling ptr deref, instead check inbounds on projections [#114330](https://github.com/rust-lang/rust/pull/114330) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a00c09e9d80b763fb29206b47b04e1d99c3ace96&end=e7bdc5f9f869219e8d20060b42a09ea10a837851&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:----:|:------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | - | - | 0 |
62+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.5%, 1.0%] | 17 |
63+
| Improvements ✅ <br /> (primary) | - | - | 0 |
64+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
65+
| All ❌✅ (primary) | - | - | 0 |
66+
67+
68+
#### Improvements
69+
70+
optimize zipping over array iterators [#115515](https://github.com/rust-lang/rust/pull/115515) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e292fec36880f48101bda4054be37097312e73c0&end=0d410be23c45e2f3567a6ec35985f690473f9176&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 3 |
77+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
78+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 3 |
79+
80+
81+
#### Mixed
82+
83+
Also consider call and yield as MIR SSA. [#113915](https://github.com/rust-lang/rust/pull/113915) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c30b28bdc17f1da73515afa0886f0d4f55c76e1f&end=d627cf07ce46d230a93732a4714d16f00df9466b&stat=instructions:u)
84+
85+
| (instructions:u) | mean | range | count |
86+
|:----------------------------------:|:-----:|:--------------:|:-----:|
87+
| Regressions ❌ <br /> (primary) | 3.9% | [3.9%, 3.9%] | 1 |
88+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 2 |
89+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.9%, -0.2%] | 26 |
90+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.3%] | 5 |
91+
| All ❌✅ (primary) | -0.2% | [-0.9%, 3.9%] | 27 |
92+
93+
94+
Rollup of 5 pull requests [#116640](https://github.com/rust-lang/rust/pull/116640) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c1691db366c0f2e2341c60377c248ca2d9335076&end=475c71da0710fd1d40c046f9cee04b733b5b2b51&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | - | - | 0 |
99+
| Regressions ❌ <br /> (secondary) | 1.1% | [1.1%, 1.1%] | 1 |
100+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 4 |
101+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.4%] | 6 |
102+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 4 |
103+
104+
105+
exhaustiveness: Rework constructor splitting [#116391](https://github.com/rust-lang/rust/pull/116391) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=df4379b4eb5357263f0cf75475953f9b5c48c31f&end=e20cb7702117f1ad8127a16406ba9edd230c4f65&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 4 |
110+
| Regressions ❌ <br /> (secondary) | 3.9% | [0.5%, 5.8%] | 9 |
111+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
112+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
113+
| All ❌✅ (primary) | 0.1% | [-0.4%, 0.3%] | 5 |
114+
115+
116+
Automatically enable cross-crate inlining for small functions [#116505](https://github.com/rust-lang/rust/pull/116505) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ca89f732ec0f910fc92111a45dd7e6829baa9d4b&end=5d5edf0248d967baa6ac5cbea09b91c7c9947942&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:---------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | 2.3% | [0.3%, 13.0%] | 8 |
121+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 0.8%] | 2 |
122+
| Improvements ✅ <br /> (primary) | -1.2% | [-18.1%, -0.1%] | 148 |
123+
| Improvements ✅ <br /> (secondary) | -2.2% | [-39.8%, -0.2%] | 209 |
124+
| All ❌✅ (primary) | -1.0% | [-18.1%, 13.0%] | 156 |
125+
126+
127+
#### Untriaged Pull Requests
128+
129+
- [#116742 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/116742)
130+
- [#116640 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/116640)
131+
- [#116492 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/116492)
132+
- [#116391 exhaustiveness: Rework constructor splitting](https://github.com/rust-lang/rust/pull/116391)
133+
- [#116183 Always preserve DebugInfo in DeadStoreElimination.](https://github.com/rust-lang/rust/pull/116183)
134+
- [#115762 Explain revealing of opaque types in layout_of ParamEnv](https://github.com/rust-lang/rust/pull/115762)
135+
- [#115751 some inspect improvements](https://github.com/rust-lang/rust/pull/115751)
136+
- [#115740 Cache reachable_set on disk](https://github.com/rust-lang/rust/pull/115740)
137+
- [#115252 Represent MIR composite debuginfo as projections instead of aggregates](https://github.com/rust-lang/rust/pull/115252)
138+
- [#115082 Fix races conditions with `SyntaxContext` decoding](https://github.com/rust-lang/rust/pull/115082)
139+
- [#115025 Make subtyping explicit in MIR](https://github.com/rust-lang/rust/pull/115025)
140+
- [#114892 Remove conditional use of `Sharded` from query caches](https://github.com/rust-lang/rust/pull/114892)
141+
- [#114481 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/114481)
142+
- [#114459 Do not run ConstProp on mir_for_ctfe.](https://github.com/rust-lang/rust/pull/114459)
143+
- [#114330 don't UB on dangling ptr deref, instead check inbounds on projections](https://github.com/rust-lang/rust/pull/114330)
144+
- [#114321 get auto traits for parallel rustc](https://github.com/rust-lang/rust/pull/114321)
145+
- [#114023 Warn on inductive cycle in coherence leading to impls being considered not overlapping](https://github.com/rust-lang/rust/pull/114023)
146+
- [#114004 Add `riscv64gc-unknown-hermit` target](https://github.com/rust-lang/rust/pull/114004)
147+
- [#113858 Always const-prop scalars and scalar pairs](https://github.com/rust-lang/rust/pull/113858)
148+
- [#113758 Turn copy into moves during DSE.](https://github.com/rust-lang/rust/pull/113758)
149+
- [#113485 Bump version to 1.73](https://github.com/rust-lang/rust/pull/113485)
150+
- [#113370 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/113370)
151+
- [#113320 Add some extra information to opaque type cycle errors](https://github.com/rust-lang/rust/pull/113320)
152+
- [#113306 Update debuginfo test runner to provide more useful output](https://github.com/rust-lang/rust/pull/113306)
153+
- [#113304 Upgrade to indexmap 2.0.0](https://github.com/rust-lang/rust/pull/113304)
154+
- [#113270 perform TokenStream replacement in-place when possible in expand_macro](https://github.com/rust-lang/rust/pull/113270)
155+
- [#113057 Rollup of 2 pull requests](https://github.com/rust-lang/rust/pull/113057)
156+
- [#112963 Stop bubbling out hidden types from the eval obligation queries](https://github.com/rust-lang/rust/pull/112963)
157+
- [#112882 Rewrite `UnDerefer`](https://github.com/rust-lang/rust/pull/112882)
158+
- [#112420 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/112420)
159+
160+
#### Nags requiring follow up
161+
162+
TODO: Nags
163+

0 commit comments

Comments
 (0)