Rust 1.66.0 install.sh fails when --without flag is used

[jonhoo]

The 1.66.0 release broke something around the --without flag to install.sh. If I download and extract https://static.rust-lang.org/dist/rust-1.66.0-x86_64-unknown-linux-gnu.tar.gz, and then run, say

./install.sh --prefix="$PWD/installed" --without=rust-analyzer

it errors out with

install: uninstalling component 'rustc'
install: uninstalling component 'rust-std-x86_64-unknown-linux-gnu'
install: creating uninstall script at /home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/installed/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'rust-std-x86_64-unknown-linux-gnu'
install: installing component 'rust-docs'
install: installing component 'rust-docs-json-preview'
install: installing component 'rust-demangler-preview'
install: installing component 'cargo'
install: installing component 'rustfmt-preview'
install: installing component 'rls-preview'
install: installing component '-preview'
install: error: manifest for -preview does not exist at /home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/-preview/manifest.in. see logs at '/home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/installed/lib/rustlib/install.log'

The same thing happens when other components are named in --without. The install completes successfully when --without isn't used. It appears the problem is with the new rust-docs-json-preview component, because the install is successful with

./install.sh --prefix="$PWD/installed" --without=rust-docs-json-preview

[Mark-Simulacrum]

I think given the workaround this is P-low.

[jonhoo]

Note that the workaround doesn't work when combined with rust-docs, so:

$ ./install.sh --prefix="$PWD/installed" --without=rust-docs,rust-docs-json-preview
install: creating uninstall script at /home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/installed/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'rust-std-x86_64-unknown-linux-gnu'
install: installing component '-json-preview'
install: error: manifest for -json-preview does not exist at /home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/-json-preview/manifest.in. see logs at '/home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/installed/lib/rustlib/install.log'

[jonhoo]

rust-analysis also appears to be broken:

$ ./install.sh --prefix="$PWD/installed" --without=rust-analysis
install: creating uninstall script at /home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/installed/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'rust-std-x86_64-unknown-linux-gnu'
install: installing component 'rust-docs'
install: installing component 'rust-docs-json-preview'
install: installing component 'rust-demangler-preview'
install: installing component 'cargo'
install: installing component 'rustfmt-preview'
install: installing component 'rls-preview'
install: installing component 'rust-analyzer-preview'
install: installing component 'llvm-tools-preview'
install: installing component 'clippy-preview'
install: installing component '-x86_64-unknown-linux-gnu'
install: error: manifest for -x86_64-unknown-linux-gnu does not exist at /home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/-x86_64-unknown-linux-gnu/manifest.in. see logs at '/home/jongje/166/rust-1.66.0-x86_64-unknown-linux-gnu/installed/lib/rustlib/install.log'

[Mark-Simulacrum]

I think we stopped shipping rust-analysis at some point?

Oh: probably not yet: #101841.

[JakubOnderka]

I think given the workaround this is P-low.

I think you should reprioritize this issue as this workaround doesn't work when other components are mentioned in --without argument as mentioned by @jonhoo. This issue affects building our internal rust Docker image.