Skip to content

consider using a different hash than SipHash for integer keys in rustc #10586

Closed
@thestinger

Description

@thestinger

You'll always be able to craft inputs for rustc making it hit a pathological compile-time and I don't think we need to protect against this. SipHash is pretty fast for strings, but on short fixed-size key types it's very slow. The compiler depends heavily on the speed of looking up integer keys in maps, so this is a huge performance cost.

(I'll post benchmark numbers soon)

Metadata

Metadata

Assignees

No one assigned

    Labels

    I-compiletimeIssue: Problems and improvements with respect to compile times.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions