`make check` fails on OSX

[dwrensha]

I get this error:

...
maketest: c-static-dylib
----- /Users/davidrenshaw/Code/rust/src/test/run-make/c-static-dylib/ --------------------
------ stdout ---------------------------------------------
gcc -Wall -Werror -g -fPIC -m64 -arch x86_64 -L /Users/davidrenshaw/Code/rust/x86_64-apple-darwin/test/run-make/c-static-dylib -c -o /Users/davidrenshaw/Code/rust/x86_64-apple-darwin/test/run-make/c-static-dylib/libcfoo.o cfoo.c

------ stderr ---------------------------------------------
clang: error: argument unused during compilation: '-L/Users/davidrenshaw/Code/rust/x86_64-apple-darwin/test/run-make/c-static-dylib'
make[1]: *** [/Users/davidrenshaw/Code/rust/x86_64-apple-darwin/test/run-make/c-static-dylib/libcfoo.o] Error 1

This patch seems to fix the problem for me: dwrensha@1693b81

[alexcrichton]

This should have been fixed by #10771. Are you using an older version of rust?

[dwrensha]

I'm using a version from a few hours ago, and I've tried clobbering any local state with git clean -fdx. The error still happens. :/

[alexcrichton]

What revision are you using?

[dwrensha]

ad58e2c

[erickt]

@alexcrichton: I am also running into this error on OSX 10.9, on 1b12dca.

[metajack]

This is a 10.9 error. You can work around it by removing -L $(TMPDIR) from tools.mk. However this is likely to break the build on other platforms.

[metajack]

I think it's caused by Clang implicitly including the current directory as a link argument. Since there is no gcc on 10.9 anymore, this has started happening.

[erickt]

@metajack: I think I found a proper fix. If you change config.mk to have CFG_C_COMPILER=clang, I managed to get passed this build issue with c-static-dylib. So we should change configure to use clang by default if it detects we are on 10.9.

[cadencemarseille]

Another option is to add -Qunused-arguments to the CC := ... line in src/test/run-make/tools.mk:

--- a/src/test/run-make/tools.mk
+++ b/src/test/run-make/tools.mk
@@ -1,5 +1,5 @@
 RUSTC := $(RUSTC) --out-dir $(TMPDIR) -L $(TMPDIR)
-CC := $(CC) -L $(TMPDIR)
+CC := $(CC) -Qunused-arguments -L $(TMPDIR)
 
 RUN = $(TMPDIR)/$(1)
 FAILS = $(TMPDIR)/$(1) && exit 1 || exit 0

See: http://stackoverflow.com/questions/13238511/xcode-clang-clang-warning-argument-unused-during-compilation-fcheck-new

[metajack]

This is probably not quite enough since this option doesn't seem to exist in gcc. Do we have a CFG variable that detects whether we're using clang or gcc?