./x.py check broken with vendored dependencies

[bjorn3]

I tried to run ./x.py check after vendoring all dependencies.

I expected to see this happen: It passes.

Instead, this happened: It tries to check rustc_codegen_gcc, despite the dependencies of cg_gcc not being vendored.

Checking stage0 gcc (aarch64-unknown-linux-gnu)
    Updating git repository `https://github.com/antoyo/gccjit.rs`
error: failed to get `gccjit` as a dependency of package `rustc_codegen_gcc v0.1.0 (/home/gh-bjorn3/rust/compiler/rustc_codegen_gcc)`

Caused by:
  failed to load source for dependency `gccjit`

Caused by:
  Unable to update https://github.com/antoyo/gccjit.rs#fe242b7e

Caused by:
  failed to fetch into: /home/gh-bjorn3/.cargo/git/db/gccjit.rs-13c2e290f2fb9e4d

Caused by:
  attempting to update a git repository, but --frozen was specified
Build completed unsuccessfully in 0:00:38

Meta

https://github.com/antoyo/gccjit.rs is GPL-3.0 licensed just like libgccjit. I don't know if there would be any issues with adding it to the rustc-src tarball.

[bjorn3]

cc @antoyo

[Kobzol]

@bjorn3 do you consider this to be solved after #114415?

[bjorn3]

Yes, though vendoring will need to be implemented for it at one point.

[Kobzol]

Ok, then probably a separate issue is to implement vendoring for the gcc backend.

[onur-ozkan]

Re-opening the issue as it's linked with a FIXME note in bootstrap.

rust/src/bootstrap/src/core/build_steps/check.rs

Lines 275 to 278 in 7717a30

	// FIXME: remove once https://github.com/rust-lang/rust/issues/112393 is resolved
	if builder.build.config.vendor && self.backend == "gcc" {
	println!("Skipping checking of `rustc_codegen_gcc` with vendoring enabled.");
	return;