Skip to content

Rustdoc's should_fail isn't very useful #11698

Closed
@alexcrichton

Description

@alexcrichton

Right now a should_fail doc test will succeed if either compilation fails or the test itself fails. The purpose of testing documentation is to fight bitrot, and if we're succeeding on bitrot, that's not too useful.

Rustdoc should always fail if compilation fails, and it should then fail or succeed depending on the result of the test itself and the presence of the should_fail attribute.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions