Skip to content

check_validity_requirement (called from clippy) throws an ICE for std::cell::UnsafeCell #119620

Closed
@PartiallyUntyped

Description

@PartiallyUntyped

Hi, I began investigating this piece of code that causes an ICE in clippy (rust-lang/rust-clippy#12032). I triaged the issue to check_validity_requirement getting called with:

(ValidityRequirement::Uninit, cx.param_env.and(ty))

where cx.param_env.and(ty) evaluates to

ParamEnvAnd {
    param_env: ParamEnv {
        caller_bounds: [
            Binder { value: TraitPredicate(<S as std::marker::Sized>, polarity:Positive), bound_vars: [] },
        ],
        reveal: UserFacing,
    },
    value: std::cell::UnsafeCell<*mut S/#0>,
}

The code that causes this is this

Code

use std::cell::UnsafeCell;

unsafe fn _check<S>() {
    let mut vec = Vec::<UnsafeCell<*mut S>>::with_capacity(1);
    vec.set_len(1);
}

when we try to check for clippy::uninit_vec.

Meta

I was able to reproduce this in nightly and stable.

Error output

Backtrace from playground:

 Checking playground v0.0.1 (/playground)
error: internal compiler error: /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/compiler/rustc_middle/src/ty/layout.rs:971:21: failed to get layout for `*mut S`: Unknown(Alias(Projection, AliasTy { args: [S/#0], def_id: DefId(2:1884 ~ core[982b]::ptr::metadata::Pointee::Metadata) })),
                                despite it being a field (#0) of an existing layout: TyAndLayout {
                                    ty: std::cell::UnsafeCell<*mut S>,
                                    layout: Layout {
                                        size: Size(8 bytes),
                                        align: AbiAndPrefAlign {
                                            abi: Align(8 bytes),
                                            pref: Align(8 bytes),
                                        },
                                        abi: Scalar(
                                            Initialized {
                                                value: Pointer(
                                                    AddressSpace(
                                                        0,
                                                    ),
                                                ),
                                                valid_range: 0..=18446744073709551615,
                                            },
                                        ),
                                        fields: Arbitrary {
                                            offsets: [
                                                Size(0 bytes),
                                            ],
                                            memory_index: [
                                                0,
                                            ],
                                        },
                                        largest_niche: None,
                                        variants: Single {
                                            index: 0,
                                        },
                                        max_repr_align: None,
                                        unadjusted_abi_align: Align(8 bytes),
                                    },
                                }

thread 'rustc' panicked at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/compiler/rustc_errors/src/lib.rs:1068:30:
Box<dyn Any>
stack backtrace:
   0:     0x7f1a652749a6 - std::backtrace_rs::backtrace::libunwind::trace::h6e733a61aeceb3b1
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:     0x7f1a652749a6 - std::backtrace_rs::backtrace::trace_unsynchronized::ha07b65a8932a3626
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x7f1a652749a6 - std::sys_common::backtrace::_print_fmt::h2e5f838db9b0d22c
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/sys_common/backtrace.rs:68:5
   3:     0x7f1a652749a6 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h7af3c390dbd3e7e4
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/sys_common/backtrace.rs:44:22
   4:     0x7f1a652c70c0 - core::fmt::rt::Argument::fmt::hdc23c83d9162de82
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/core/src/fmt/rt.rs:142:9
   5:     0x7f1a652c70c0 - core::fmt::write::h980076999ca48f88
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/core/src/fmt/mod.rs:1120:17
   6:     0x7f1a652683cf - std::io::Write::write_fmt::hfe3709eb2de31f02
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/io/mod.rs:1810:15
   7:     0x7f1a65274784 - std::sys_common::backtrace::_print::hdd8ca13784a9622e
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/sys_common/backtrace.rs:47:5
   8:     0x7f1a65274784 - std::sys_common::backtrace::print::he8955e9a8553aa6a
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/sys_common/backtrace.rs:34:9
   9:     0x7f1a65277517 - std::panicking::default_hook::{{closure}}::h926e5698ad37617c
  10:     0x7f1a65277279 - std::panicking::default_hook::h5497cc288401160a
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/panicking.rs:292:9
  11:     0x7f1a68058d1c - std[ad4b8f867feff437]::panicking::update_hook::<alloc[bcb00b40dbbdb0d3]::boxed::Box<rustc_driver_impl[8a1fda2214610a7d]::install_ice_hook::{closure#0}>>::{closure#0}
  12:     0x7f1a65277c66 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h6819ff2410a24297
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/alloc/src/boxed.rs:2029:9
  13:     0x7f1a65277c66 - std::panicking::rust_panic_with_hook::h9c9b9f939d288829
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/panicking.rs:783:13
  14:     0x7f1a68091a14 - std[ad4b8f867feff437]::panicking::begin_panic::<rustc_errors[6c23686e783cce7a]::ExplicitBug>::{closure#0}
  15:     0x7f1a6808e156 - std[ad4b8f867feff437]::sys_common::backtrace::__rust_end_short_backtrace::<std[ad4b8f867feff437]::panicking::begin_panic<rustc_errors[6c23686e783cce7a]::ExplicitBug>::{closure#0}, !>
  16:     0x7f1a6808db06 - std[ad4b8f867feff437]::panicking::begin_panic::<rustc_errors[6c23686e783cce7a]::ExplicitBug>
  17:     0x7f1a6809c961 - <rustc_errors[6c23686e783cce7a]::diagnostic_builder::BugAbort as rustc_errors[6c23686e783cce7a]::diagnostic_builder::EmissionGuarantee>::emit_producing_guarantee
  18:     0x7f1a6846602e - <rustc_errors[6c23686e783cce7a]::DiagCtxt>::bug::<alloc[bcb00b40dbbdb0d3]::string::String>
  19:     0x7f1a685022fb - rustc_middle[e05cf450071da251]::util::bug::opt_span_bug_fmt::<rustc_span[b600bae4f070df3d]::span_encoding::Span>::{closure#0}
  20:     0x7f1a684eabfa - rustc_middle[e05cf450071da251]::ty::context::tls::with_opt::<rustc_middle[e05cf450071da251]::util::bug::opt_span_bug_fmt<rustc_span[b600bae4f070df3d]::span_encoding::Span>::{closure#0}, !>::{closure#0}
  21:     0x7f1a684eaa98 - rustc_middle[e05cf450071da251]::ty::context::tls::with_context_opt::<rustc_middle[e05cf450071da251]::ty::context::tls::with_opt<rustc_middle[e05cf450071da251]::util::bug::opt_span_bug_fmt<rustc_span[b600bae4f070df3d]::span_encoding::Span>::{closure#0}, !>::{closure#0}, !>
  22:     0x7f1a66476a70 - rustc_middle[e05cf450071da251]::util::bug::bug_fmt
  23:     0x7f1a69322913 - <rustc_const_eval[f70e0310a347ca5b]::interpret::eval_context::InterpCx<rustc_const_eval[f70e0310a347ca5b]::const_eval::machine::CompileTimeInterpreter>>::project_field::<rustc_const_eval[f70e0310a347ca5b]::interpret::operand::OpTy>
  24:     0x7f1a693c2740 - <rustc_const_eval[f70e0310a347ca5b]::interpret::validity::ValidityVisitor<rustc_const_eval[f70e0310a347ca5b]::const_eval::machine::CompileTimeInterpreter> as rustc_const_eval[f70e0310a347ca5b]::interpret::visitor::ValueVisitor<rustc_const_eval[f70e0310a347ca5b]::const_eval::machine::CompileTimeInterpreter>>::visit_value
  25:     0x7f1a6800e643 - <rustc_const_eval[f70e0310a347ca5b]::interpret::eval_context::InterpCx<rustc_const_eval[f70e0310a347ca5b]::const_eval::machine::CompileTimeInterpreter>>::validate_operand_internal
  26:     0x7f1a6a24639c - rustc_const_eval[f70e0310a347ca5b]::util::check_validity_requirement::check_validity_requirement
  27:     0x7f1a6a2461d4 - <rustc_const_eval[f70e0310a347ca5b]::provide::{closure#2} as core[982b8df6c967a8a5]::ops::function::FnOnce<(rustc_middle[e05cf450071da251]::ty::context::TyCtxt, (rustc_middle[e05cf450071da251]::ty::layout::ValidityRequirement, rustc_middle[e05cf450071da251]::ty::ParamEnvAnd<rustc_middle[e05cf450071da251]::ty::Ty>))>>::call_once
  28:     0x7f1a6a2461af - rustc_query_impl[4e3781ebe67b5ecd]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[4e3781ebe67b5ecd]::query_impl::check_validity_requirement::dynamic_query::{closure#2}::{closure#0}, rustc_middle[e05cf450071da251]::query::erase::Erased<[u8; 16usize]>>
  29:     0x7f1a6a246167 - <rustc_query_impl[4e3781ebe67b5ecd]::query_impl::check_validity_requirement::dynamic_query::{closure#2} as core[982b8df6c967a8a5]::ops::function::FnOnce<(rustc_middle[e05cf450071da251]::ty::context::TyCtxt, (rustc_middle[e05cf450071da251]::ty::layout::ValidityRequirement, rustc_middle[e05cf450071da251]::ty::ParamEnvAnd<rustc_middle[e05cf450071da251]::ty::Ty>))>>::call_once
  30:     0x7f1a6a245c7a - rustc_query_system[9f47fcc3ed12af35]::query::plumbing::try_execute_query::<rustc_query_impl[4e3781ebe67b5ecd]::DynamicConfig<rustc_query_system[9f47fcc3ed12af35]::query::caches::DefaultCache<(rustc_middle[e05cf450071da251]::ty::layout::ValidityRequirement, rustc_middle[e05cf450071da251]::ty::ParamEnvAnd<rustc_middle[e05cf450071da251]::ty::Ty>), rustc_middle[e05cf450071da251]::query::erase::Erased<[u8; 16usize]>>, false, false, false>, rustc_query_impl[4e3781ebe67b5ecd]::plumbing::QueryCtxt, false>
  31:     0x7f1a6a245961 - rustc_query_impl[4e3781ebe67b5ecd]::query_impl::check_validity_requirement::get_query_non_incr::__rust_end_short_backtrace
  32:     0x561af7d6a799 - clippy_utils[72f0f6e3cedd6d1c]::ty::is_uninit_value_valid_for_ty
  33:     0x561af7c59547 - clippy_lints[a4a8a8bcbc5737e3]::uninit_vec::handle_uninit_vec_pair
  34:     0x561af7c59123 - <clippy_lints[a4a8a8bcbc5737e3]::uninit_vec::UninitVec as rustc_lint[d33e387eec082aaa]::passes::LateLintPass>::check_block
  35:     0x7f1a683e1df8 - <rustc_lint[d33e387eec082aaa]::late::LateContextAndPass<rustc_lint[d33e387eec082aaa]::late::RuntimeCombinedLateLintPass> as rustc_hir[1cdea0862ecbaa6e]::intravisit::Visitor>::visit_block
  36:     0x7f1a683e16cf - <rustc_lint[d33e387eec082aaa]::late::LateContextAndPass<rustc_lint[d33e387eec082aaa]::late::RuntimeCombinedLateLintPass> as rustc_hir[1cdea0862ecbaa6e]::intravisit::Visitor>::visit_expr::{closure#0}
  37:     0x7f1a683e0ef8 - <rustc_lint[d33e387eec082aaa]::late::LateContextAndPass<rustc_lint[d33e387eec082aaa]::late::RuntimeCombinedLateLintPass> as rustc_hir[1cdea0862ecbaa6e]::intravisit::Visitor>::visit_expr
  38:     0x7f1a683df7ca - <rustc_lint[d33e387eec082aaa]::late::LateContextAndPass<rustc_lint[d33e387eec082aaa]::late::RuntimeCombinedLateLintPass> as rustc_hir[1cdea0862ecbaa6e]::intravisit::Visitor>::visit_nested_body
  39:     0x7f1a683e1a64 - <rustc_lint[d33e387eec082aaa]::late::LateContextAndPass<rustc_lint[d33e387eec082aaa]::late::RuntimeCombinedLateLintPass> as rustc_hir[1cdea0862ecbaa6e]::intravisit::Visitor>::visit_fn
  40:     0x7f1a683e000f - <rustc_lint[d33e387eec082aaa]::late::LateContextAndPass<rustc_lint[d33e387eec082aaa]::late::RuntimeCombinedLateLintPass> as rustc_hir[1cdea0862ecbaa6e]::intravisit::Visitor>::visit_item
  41:     0x7f1a683e1d9a - <rustc_lint[d33e387eec082aaa]::late::LateContextAndPass<rustc_lint[d33e387eec082aaa]::late::RuntimeCombinedLateLintPass> as rustc_hir[1cdea0862ecbaa6e]::intravisit::Visitor>::visit_mod
  42:     0x7f1a69f4c7a6 - rustc_lint[d33e387eec082aaa]::late::check_crate::{closure#0}
  43:     0x7f1a69f4c9f5 - rustc_lint[d33e387eec082aaa]::late::check_crate
  44:     0x7f1a69be8cc2 - rustc_interface[5b3f00bef9c74c50]::passes::analysis
  45:     0x7f1a69be7adf - rustc_query_impl[4e3781ebe67b5ecd]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[4e3781ebe67b5ecd]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[e05cf450071da251]::query::erase::Erased<[u8; 1usize]>>
  46:     0x7f1a6a2989e4 - rustc_query_system[9f47fcc3ed12af35]::query::plumbing::try_execute_query::<rustc_query_impl[4e3781ebe67b5ecd]::DynamicConfig<rustc_query_system[9f47fcc3ed12af35]::query::caches::SingleCache<rustc_middle[e05cf450071da251]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[4e3781ebe67b5ecd]::plumbing::QueryCtxt, false>
  47:     0x7f1a6a2987d5 - rustc_query_impl[4e3781ebe67b5ecd]::query_impl::analysis::get_query_non_incr::__rust_end_short_backtrace
  48:     0x7f1a6a3305f5 - rustc_interface[5b3f00bef9c74c50]::interface::run_compiler::<core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>, rustc_driver_impl[8a1fda2214610a7d]::run_compiler::{closure#0}>::{closure#0}
  49:     0x7f1a6a2b6c46 - std[ad4b8f867feff437]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[5b3f00bef9c74c50]::util::run_in_thread_with_globals<rustc_interface[5b3f00bef9c74c50]::util::run_in_thread_pool_with_globals<rustc_interface[5b3f00bef9c74c50]::interface::run_compiler<core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>, rustc_driver_impl[8a1fda2214610a7d]::run_compiler::{closure#0}>::{closure#0}, core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>>::{closure#0}, core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>>
  50:     0x7f1a6a2b6a73 - <<std[ad4b8f867feff437]::thread::Builder>::spawn_unchecked_<rustc_interface[5b3f00bef9c74c50]::util::run_in_thread_with_globals<rustc_interface[5b3f00bef9c74c50]::util::run_in_thread_pool_with_globals<rustc_interface[5b3f00bef9c74c50]::interface::run_compiler<core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>, rustc_driver_impl[8a1fda2214610a7d]::run_compiler::{closure#0}>::{closure#0}, core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>>::{closure#0}, core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[982b8df6c967a8a5]::result::Result<(), rustc_span[b600bae4f070df3d]::ErrorGuaranteed>>::{closure#1} as core[982b8df6c967a8a5]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  51:     0x7f1a65281b95 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h5319a960a245b9e6
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/alloc/src/boxed.rs:2015:9
  52:     0x7f1a65281b95 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::he20b241104330ff5
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/alloc/src/boxed.rs:2015:9
  53:     0x7f1a65281b95 - std::sys::unix::thread::Thread::new::thread_start::h76e8c5cd6de24057
                               at /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/std/src/sys/unix/thread.rs:108:17
  54:     0x7f1a65189609 - start_thread
  55:     0x7f1a64f5d353 - clone
  56:                0x0 - <unknown>

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new?template=ice.yml

note: please attach the file at `/playground/rustc-ice-2024-01-05T15_07_43-21.txt` to your bug report

note: compiler flags: --crate-type bin -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [check_validity_requirement] checking validity requirement for `core::cell::UnsafeCell<*mut S>`: allows being left uninitialized
#1 [analysis] running analysis passes on this crate
end of query stack
note: Clippy version: clippy 0.1.77 (f688dd6 2024-01-04)

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.I-ICEIssue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions