Skip to content

tests/ui/treat-err-as-bug/panic-causes-oom-112708.rs is very slow after #121927 #122009

Closed
@Zalathar

Description

@Zalathar
//@ compile-flags: -Ztreat-err-as-bug
//@ dont-check-failure-status
//@ error-pattern: aborting due to `-Z treat-err-as-bug=1`
//@ dont-check-compiler-stderr
//@ rustc-env:RUST_BACKTRACE=0

fn main() {
    #[deny(while_true)]
    while true {}
}

When doing x test ui, I noticed that this particular test now takes a very long time to run. I was able to bisect the change down to #121927.

# BEFORE
$ git checkout cd9e5b5f && x test ui -- panic-causes-oom --force-rerun
...
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 16251 filtered out; finished in 26.35ms

# AFTER
$ git checkout de95c39a && x test ui -- panic-causes-oom --force-rerun
...
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 16251 filtered out; finished in 103.41s

(Notice the jump from milliseconds to seconds.)

@rustbot label +A-testsuite +A-contributor-roadblock +T-compiler

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustA-testsuiteArea: The testsuite used to check the correctness of rustcT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions