regression: compiler had non-unwinding abort

[Mark-Simulacrum]

• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/gh/InfiniteCoder01.GarbageCollector2/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/reg/regexp2rust_macro-0.1.5/log.txt

[INFO] [stderr] thread caused non-unwinding panic. aborting.
[INFO] [stderr] error: could not compile `garbage_collector2` (bin "garbage_collector2")
[INFO] [stderr] 
[INFO] [stderr] Caused by:
[INFO] [stderr]   process didn't exit successfully: `/opt/rustwide/rustup-home/toolchains/beta-2024-03-30-x86_64-unknown-linux-gnu/bin/rustc --crate-name garbage_collector2 --edition=2021 src/main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 -C metadata=857ded4589b0897a -C extra-filename=-857ded4589b0897a --out-dir /opt/rustwide/target/debug/deps -L dependency=/opt/rustwide/target/debug/deps --extern anyhow=/opt/rustwide/target/debug/deps/libanyhow-4ba56e5ce709e35c.rlib --extern bidivec=/opt/rustwide/target/debug/deps/libbidivec-03555ce9cb9a7e42.rlib --extern console_error_panic_hook=/opt/rustwide/target/debug/deps/libconsole_error_panic_hook-0f6527b0603b2eb8.rlib --extern getrandom=/opt/rustwide/target/debug/deps/libgetrandom-b4d6e3ffd9dfac91.rlib --extern instant=/opt/rustwide/target/debug/deps/libinstant-11857eb893fd2c6b.rlib --extern laps=/opt/rustwide/target/debug/deps/liblaps-f7a69f6626767932.rlib --extern map_macro=/opt/rustwide/target/debug/deps/libmap_macro-71bc2494c68bef75.rlib --extern rand=/opt/rustwide/target/debug/deps/librand-0a6d206a676e4578.rlib --extern ron=/opt/rustwide/target/debug/deps/libron-3d88a0ce6119ff9c.rlib --extern serde=/opt/rustwide/target/debug/deps/libserde-e7a2b4f62285ba72.rlib --extern speedy2d=/opt/rustwide/target/debug/deps/libspeedy2d-93be5c445316c833.rlib --cap-lints=warn` (signal: 6, SIGABRT: process abort signal)

[saethlin]

The regression in InfiniteCoder01/GarbageCollector2 is a failing precondition check in a library used in a proc macro:

#11 0x00007af93a1375c5 in core::panicking::panic_nounwind () at library/core/src/panicking.rs:215
#12 0x00007af93a258e38 in core::char::convert::from_u32_unchecked::precondition_check ()
   from /tmp/GarbageCollector2/target/debug/deps/liblaps_macros-ee19be92fda0179c.so
#13 0x00007af93a258e50 in core::char::methods::<impl char>::from_u32_unchecked ()
   from /tmp/GarbageCollector2/target/debug/deps/liblaps_macros-ee19be92fda0179c.so
#14 0x00007af93a25a140 in <char as laps_regex::mir::SymbolOp>::next ()
   from /tmp/GarbageCollector2/target/debug/deps/liblaps_macros-ee19be92fda0179c.so
#15 0x00007af93a1f93aa in laps_regex::mir::Mir<S,T>::symbol_set ()
   from /tmp/GarbageCollector2/target/debug/deps/liblaps_macros-ee19be92fda0179c.so
#16 0x00007af93a2022bb in laps_regex::mir::Mir<S,T>::optimize ()
   from /tmp/GarbageCollector2/target/debug/deps/liblaps_macros-ee19be92fda0179c.so
#17 0x00007af93a22a620 in laps_regex::re::RegexBuilder<T>::build_impl ()
   from /tmp/GarbageCollector2/target/debug/deps/liblaps_macros-ee19be92fda0179c.so
#18 0x00007af93a22b0bd in laps_regex::re::RegexBuilder<T>::build ()

The regression in regexp2rust_macro is a failing precondition check in wasmer:

#11 0x000070261e30d3a5 in core::panicking::panic_nounwind () at library/core/src/panicking.rs:215
#12 0x000070261ecb66ad in core::intrinsics::copy::precondition_check (src=0x70261cd5f000, dst=0x70261c64aaec, align=8)
    at /rustc/805813650248c1a2f6f271460d728d1bb852d2a7/library/core/src/ub_checks.rs:66
#13 0x000070261eca33c4 in core::intrinsics::copy<wasmer_vm::vmcontext::VMFunctionImport> (src=0x70261cd5f000, 
    dst=0x70261c64aaec, count=10) at /rustc/805813650248c1a2f6f271460d728d1bb852d2a7/library/core/src/intrinsics.rs:2975
#14 wasmer_vm::instance::InstanceHandle::new (allocator=..., module=..., context=0x70262c94d900, finished_functions=..., 
    finished_function_call_trampolines=..., finished_memories=..., finished_tables=..., finished_globals=..., imports=..., 
    vmshared_signatures=...) at src/instance/mod.rs:899
#15 0x000070261ec57d48 in wasmer_compiler::engine::artifact::Artifact::instantiate (self=0x70261c663810, tunables=..., 
    imports=..., context=0x70262c94d900) at src/engine/artifact.rs:376
#16 0x000070261e4738d2 in wasmer::sys::module::Module::instantiate<wasmer::sys::store::Store> (self=0x70262d3defe8, 
    store=0x70262d3defc0, imports=...)
    at /home/ben/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasmer-3.0.2/src/sys/module.rs:361
#17 0x000070261e325516 in wasmer::sys::instance::Instance::new<wasmer::sys::store::Store> (store=0x70262d3defc0, 
    module=0x70262d3defe8, imports=0x70262d3df160)
    at /home/ben/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasmer-3.0.2/src/sys/instance.rs:121
#18 0x000070261e31b62a in jsexec::runjs (source=...) at src/lib.rs:21
#19 0x000070261e3115e0 in regexp2rust_macro::run ()

At most this is asking for proc-macros to be able to report panic messages, but really these are just more of #123285. People were executing UB, we now prevent that and try to tell them about it.