Skip to content

compiletest: run-rustfix and revisions have broken interactions #123596

Closed
@jieyouxu

Description

@jieyouxu

compiletest currently accepts both run-rustfix and revision directives:

  • //@ run-rustfix, and
  • //@ revisions: r1 ... rn

However, run-rustfix does not correctly account for revisions, because revisions + run-rustfix together tries to create a new crate named after each revision <test-name>.<revisions>, which is not a valid Rust crate name because of the ..

Example UI test where the author had to workaround it by explicitly setting #![crate_name]:

// FIXME: the test suite tries to create a crate called `bare_trait_dont_suggest_dyn.new`

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions