Skip to content

run-make-support: add #[must_use] to helpers where suitable #125703

Closed
@jieyouxu

Description

@jieyouxu

For command wrappers like Rustc, they often have intermediate helper methods and actual "terminal" functions that executes the built command (e.g. run, run_fail, run_fail_assert_exit_code). Currently, it is easy to forget to call "terminal" functions.

For example,

rustc().input("foo.rs").arg("-Cprefer-dynamic");

does not actually execute and can unexpectedly silently pass. We should annotate intermediate helper methods with #[must_use] to ensure the built command is consumed, i.e. by executing the command.

Metadata

Metadata

Assignees

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions