Skip to content

run-make: audit raw Command usages #126058

Closed
@jieyouxu

Description

@jieyouxu

https://github.com/rust-lang/rust/pull/125752/files would add drop bomps to command wrappers that forces the test writer to check command exit status. However, some rmake.rs tests use raw Command invocations for various reasons, and it's super easy to forget to check for command exit status.

We should probably:

  • Convert Command invocations to command wrappers where reasonable.
  • Introduce something to force a check of the exit status if for some reason a raw Command cannot be converted into a command wrapper.

Metadata

Metadata

Assignees

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions