Skip to content

Bootstrap using set_times on a read-only file #127849

Closed
@ChrisDenton

Description

@ChrisDenton

@jieyouxu noticed that bootstrap is now failing on a clean Windows build:

thread 'main' panicked at src\core\download.rs:711:13:
llvm_config_file.set_times(file_times) failed with Access is denied. (os error 5)

This fails due to the file being opened as read-only:

let llvm_config_file = t!(File::open(llvm_config));
t!(llvm_config_file.set_times(file_times));

This could be fixed using windows specific permissions but it'd be simpler to just use OpenOptions with write(true).

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustC-bugCategory: This is a bug.O-windowsOperating system: WindowsT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions