Skip to content

compiletest: -Cincremental in ui tests dump incr build output to source directories #128057

Open
@jieyouxu

Description

@jieyouxu

See #128038:

Currently tests can ICE when the test spits out inc-fat incremental artifacts directly into the top of the git checkout, and then the compiler version changes, and it reads nonsense incremental artifacts on a subsequent test run.

I think the right flag to add when porting -Cincremental run-make tests is to use //@ incremental rather than manually specifying the -Cincremental rustflag.

If manual -Cincremental specified in compile-flags cause output to the working directory (not even build directory), then we really should error and suggest //@ incremental.

Metadata

Metadata

Assignees

Labels

A-compiletestArea: The compiletest test runnerC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions