Skip to content

.eh_frame is emitted for -C panic=abort on (at least) i686-pc-windows-gnu #128136

Closed
@jieyouxu

Description

@jieyouxu

#112403 tried to prevent .eh_frame from being emitted for -Cpanic=abort and added a test (tests/run-make/panic-abort-eh_frame/Makefile) to check unnecessary landing pads related to unwinding do not appear in the object file when -Cpanic=abort.

The original Makefile test was only-linux, and when @Oneirical tried to run the (roughly) equivalent test on Windows (see #127523), we found that this "no unnecessary landing pads" property (whichever property is checked by proxy via testing if DW_CFA exists) is not preserved at least on i686-pc-windows-gnu.

I don't understand much of this test, so I'll ask those who are more knowledgeable: for people more familiar with this test cc @nbdd0121 and @Nilstrieb, is this property also intended to be upheld on Windows and not just Linux?

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlA-codegenArea: Code generationA-panicArea: Panicking machineryC-bugCategory: This is a bug.O-windowsOperating system: WindowsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions