Closed
Description
The new convenience methods on the Json class could be cleaned up a little bit:
- All of the methods use the corresponding Json enum variant in their name except for
is_str
andas_str
, which refer to the Ruststr
type. These should be madeis_string
andas_string
. - Implement the
is_*
methods in terms of theas_*
methods. find_path
uses a fold/map implementation that does not short circuit in the event of an invalid path. If a path with 10 keys is provided but the first key does not exist, it will still go through the effort of generating all 10None
s.
I'll take care of these, I just wanted to post them here in case people had other comments.
Metadata
Metadata
Assignees
Labels
No labels