Skip to content

robin-hood HashMap "tail-call" should be rewritten as a loop #12860

Closed
@pnkfelix

Description

@pnkfelix

This code:

https://github.com/mozilla/rust/blob/2eebeb81372e320510a1c1e2eef96eb5146a1e1f/src/libcollections/hashmap.rs#L1099

is believed to be causing this stack overflow:

https://gist.github.com/Meyermagic/9523484

Some cursory analysis indicates that this code shouldn't need to be using (an attempt at) tail recursion; a version that uses a loop shouldn't be a difficult refactoring. See discussion here:

https://botbot.me/mozilla/rust/msg/12053161/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions