run-make: audit the `ignore-{windows,msvc,windows-msvc}` tests

[jieyouxu]

There are several ignore-msvc/ignore-windows/ignore-windows-msvc Makefile and rmake.rs (tests that are ported to pure Rust files) run-make tests that have those ignore-*s because of several common challenges:

1. Can't figure out how to build the proper e.g. import lib for dynamic lib to satisfy link.exe.
2. Can't figure out the msvc build invocations to generate the desired output artifacts.
3. Debug info or object symbol differences versus mingw or linux or apple.
4. Weird appearance of unexpected symbols or lack of expected symbols.

It would be great and super helpful if Windows experts could take a look at them, and see if some of the ignore-*s can be resolved or otherwise how we can expand the tests to cover msvc as well, or have proper reasons why they must be ignore-*'d. The test suite is quite tricky to run on Windows, see https://rustc-dev-guide.rust-lang.org/tests/running.html?highlight=run-make#windows, seems to require msys2 + make, binutils, diffutils for the remaining Makefiles.

ignore-msvc:

• tests/run-make/used/rmake.rs (Update run-make/used to use any_symbol_contains #128603)
• tests/run-make/no-alloc-shim/Makefile
• tests/run-make/staticlib-dylib-linkage/rmake.rs (run-make: enable msvc for staticlib-dylib-linkage #128823)
• tests/run-make/no-duplicate-libs/rmake.rs (run-make: Enable msvc for no-duplicate-libs and zero-extend-abi-param-passing #128649)
• tests/run-make/link-dedup/rmake.rs (run-make: enable msvc for link-dedup #128638)
• tests/run-make/rust-lld/rmake.rs (Enable msvc for run-make/rust-lld #128656)
• tests/run-make/link-args-order/rmake.rs (Enable msvc for link-args-order #128647)
• tests/run-make/zero-extend-abi-param-passing/rmake.rs (run-make: Enable msvc for no-duplicate-libs and zero-extend-abi-param-passing #128649)

ignore-windows-msvc:

• tests/run-make/redundant-libs/rmake.rs (run-make: enable msvc for redundant-libs #128804)
• tests/run-make/symbol-visibility/rmake.rs (Use object in run-make/symbols-visibility #128607)
• tests/run-make/extern-fn-reachable/Makefile
• tests/run-make/native-link-modifier-bundle/Makefile

ignore-windows:

• tests/run-make/naked-symbol-visibility/rmake.rs
• tests/run-make/dep-info/Makefile
• tests/run-make/short-ice/rmake.rs
• tests/run-make/incr-add-rust-src-component/Makefile (symlink)
• tests/run-make/extern-fn-reachable/Makefile
• tests/run-make/dep-info/Makefile
• tests/run-make/dep-info-spaces/Makefile
• tests/run-make/lto-avoid-object-duplication/rmake.rs
• tests/run-make/translation/Makefile (symlink)
• tests/run-make/native-link-modifier-bundle/Makefile
• tests/run-make/textrel-on-minimal-lib/rmake.rs
• tests/run-make/remap-path-prefix-dwarf/Makefile
• tests/run-make/libs-through-symlinks/Makefile (symlink)
• tests/run-make/redundant-libs/Makefile
• tests/run-make/reproducible-build-2/rmake.rs (the symlink part might be possible with needs-symlink, unsure about reproducible paths)
• tests/run-make/fmt-write-bloat/rmake.rs (no_std test) (run-make: explaing why fmt-write-bloat is ignore-windows #128807)

[rustbot]

Error: Parsing ping command in comment failed: ...'ng windows' | error: expected end of command at >| ' (if our W'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[jieyouxu]

If the Windows experts could take a look when they have time, it would be very helpful :3
@rustbot ping windows

[rustbot]

Hey Windows Group! This bug has been identified as a good "Windows candidate".
In case it's useful, here are some instructions for tackling these sorts of
bugs. Maybe take a look?
Thanks! <3

cc @albertlarsan68 @arlosi @ChrisDenton @danielframpton @gdr-at-ms @kennykerr @luqmana @lzybkr @nico-abram @retep998 @sivadeilra @wesleywiser

[jieyouxu]

You can find the current run-make tests that have ignore-msvc with https://github.com/search?q=repo%3Arust-lang%2Frust%20ignore-msvc%20path%3Atests%2Frun-make&type=code as well as ignore-windows-msvc with https://github.com/search?q=repo%3Arust-lang%2Frust+ignore-windows-msvc+path%3Atests%2Frun-make&type=code.

I'm happy to help answer questions about the rmake.rs setup :3

[ChrisDenton]

I very quickly did one in #128603. It uses a library function rather than nm (using llvm-nm would also have been an option).

[ChrisDenton]

I don't have time to fix it atm but zero-extend-abi-param-passing looks like another easy one. It just needs two things.

A version of build_native_static_lib that optimizes the output. Maybe called build_native_static_lib_optimized or something. This would be exactly the same as build_native_static_lib but would also set -O3 for non-msvc and /O2 for msvc.

param_passing.rs should also be changed to use #[link(name = "bad", kind = "static")]:

rust/tests/run-make/zero-extend-abi-param-passing/param_passing.rs

Line 5 in ad0a2b7

#[link(name = "bad")]

Or the #[link] line could be removed entirely as it's set in the call to rustc.

[ChrisDenton]

Ok I've done the above now as well as the other non-Makefile tests. I've not looked at the Makefile tests yet since I'd prefer to wait until they've been ported to pure Rust as I find it much easier to work on Rust tests without the added layer of emulation.