Skip to content

compiletest::runtest: aggressive_rm_rf does not like symlinks on Windows #129155

Closed
@jieyouxu

Description

@jieyouxu

While reviewing #128562 and testing I discovered that runtest.rs's aggressive_rm_rf is not aggressive enough, unfortunately, because symlink-to-dir and symlink-to-file on Windows need different handling.

Have not considered junction points and hard links.

This can cause a rmake.rs test that creates symlinks to have its output artifacts fail to be removed on non-fresh test runs.

Metadata

Metadata

Assignees

Labels

A-compiletestArea: The compiletest test runnerA-run-makeArea: port run-make Makefiles to rmake.rsC-bugCategory: This is a bug.O-windowsOperating system: WindowsT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions