Skip to content

run-make: fix run_make_support::fs::create_symlink API and audit symlink usages in rmake.rs tests #129389

Closed
@jieyouxu

Description

@jieyouxu

I need to revisit run_make_support::fs::create_symlink because it's a wrong abstraction: there's a good reason why symlink_file/symlink_dir are different operations under std::os::windows::fs.

Furthermore, I need to double-check our symlink handling in rmake.rs tests. It's ok if symlinks are removed via fs::remove_dir_all because that has special handling for symlinks on Windows, but need to be extra careful if symlinks are attempted to be removed with fs::{remove_file, remove_dir} if the test can be run on Windows.

Metadata

Metadata

Assignees

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions