Skip to content

Stop using "Hack to avoid function merging" #129438

Closed
@scottmcm

Description

@scottmcm

There's a whole bunch of this:

tests\assembly\asm\x86-types.rs
125:            // Hack to avoid function merging
142:            // Hack to avoid function merging

tests\assembly\asm\x86-modifiers.rs
41:            // Hack to avoid function merging

tests\assembly\asm\s390x-types.rs
45:// Hack to avoid function merging

tests\assembly\asm\riscv-types.rs
93:            // Hack to avoid function merging
110:            // Hack to avoid function merging

tests\assembly\asm\powerpc-types.rs
46:// Hack to avoid function merging

tests\assembly\asm\mips-types.rs
46:// Hack to avoid function merging

tests\assembly\asm\loongarch-type.rs
42:// Hack to avoid function merging

tests\assembly\asm\hexagon-types.rs
44:            // Hack to avoid function merging
61:            // Hack to avoid function merging
80:    // Hack to avoid function merging
95:    // Hack to avoid function merging

tests\assembly\asm\arm-types.rs
120:            // Hack to avoid function merging
137:            // Hack to avoid function merging

tests\assembly\asm\arm-modifiers.rs
46:            // Hack to avoid function merging

tests\assembly\asm\aarch64-types.rs
119:            // Hack to avoid function merging
140:            // Hack to avoid function merging

tests\assembly\asm\aarch64-modifiers.rs
32:            // Hack to avoid function merging

Do we really need to hack it, though? We have a flag for that:

//@ compile-flags: -Zmerge-functions=disabled

This issue has been assigned to @Rajveer100 via this comment.

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions