`make clean` should delete the tmp directory

[nrc]

I just had a bug where make check failed at run-pass/linkage2.rs. Deleting the tmp directory solved the problem, but make clean did not. I assume make clean should delete that sort of thing.

[flaper87]

Triage bump, bug is still valid.

[tbelaire]

I don't understand why it didn't.

mk/clean.mk

 38 clean: clean-misc $(CLEAN_STAGE_RULES)
 39 
 40 clean-misc:
 41     @$(call E, cleaning)
 ...
 45     $(Q)rm -Rf tmp/*

So make clean does rm -Rf tmp/*. Perhaps it needs to delete the directory too?

Can I get more detailed steps on how to reproduce this bug, so I can tell if deleting tmp/ instead of tmp/* fixes it?

[steveklabnik]

I agree with @tbelaire , it would seem like the rules are very straightforward here, and if I run make clean, I do get a rm -Rf tmp/*. @nrc or @flaper87 , can you give any way to reproduce this?

[brson]

Ancient bug. Closing.