Skip to content

rustdoc: toolbar redesign no longer properly handles shortening of long crate names in search dropdown #130993

Closed
@steffahn

Description

@steffahn

Last time I contributed to the design of the crate selection, which was merged with the following PR

I made sure to test the handling of long crate names.

[CLICK TO EXPAND comparison screenshots with the old design]

Old Design:
Image
What happens with a long crate name:
Image

With the new design

the behavior seems a lot worse now:

[CLICK TO EXPAND comparison screenshots with the new design]

New Design:
Image
What happens with a long crate name:
Image

(Refer to the last screenshot above for the following description.)

In particular, I’m noticing that the button grows too large, shifts down a little but for some reason, and then pushes the Settings/Help/Summary control elements off-screen.

I don’t recall off the top of my head the specific HTML/CSS foo that used made this work in the first place, but possible it’s a relatively simple fix.

cc @GuillaumeGomez, @notriddle

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions