'make dist' doesn't work correctly on mac

[brson]

We use the --exclude-vcs flag to tar, which doesn't exist on Mac. I'm temorarily going to change the dist target to not produce tarballs on Mac to work around the problem on our nightly builders.

[flaper87]

Triage bump: I don't have a way to verify this but the workaround is still there.

[steveklabnik]

triage: i don't own a mac either. @brson is this part of rust-installer now?

[frewsxcv]

I can confirm that the conditional added in d2686c7 still exists currently:

https://github.com/brson/rust/blob/1d00c545ede609b9d43fdf9f252c15da5a66dac7/mk/dist.mk#L256-L261

Considering all --exclude-vcs does is ignore version control related software, one potential fix for this would be to use --exclude .git --exclude .gitmodules --exclude .gitignore which AFAIK works with both BSD and GNU tar

[steveklabnik]

Triage: still there today

rust/mk/dist.mk

Lines 352 to 357 in 8f62c29

	# FIXME #13224: On OS X don't produce tarballs simply because --exclude-vcs don't work.
	# This is a huge hack because I just don't have time to figure out another solution.
	ifeq ($(CFG_OSTYPE), apple-darwin)
	MAYBE_DIST_TAR_SRC=
	MAYBE_DISTCHECK_TAR_SRC=
	endif

[alexcrichton]

Make's now gone, so closing.

(fixed in rustbulid)