Recent pre-nightly builds have "commit-hash: unknown" in their version info

[RalfJung]

I noticed this in Miri where we currently use the 668959740f97e7a22ae340742886d330ab63950f build (via rustup-toolchain-install-master):

$ rustc +miri --version -v
rustc 1.84.0-nightly
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.3

Something seems very wrong about this?

Cc @rust-lang/compiler (sorry I don't know whom specifically to ping here)

[RalfJung]

The latest nightly is still fine

$ rustc +nightly --version -v
rustc 1.84.0-nightly (59cec72a5 2024-11-08)
binary: rustc
commit-hash: 59cec72a57af178767a7b8e7f624b06cc50f1087
commit-date: 2024-11-08
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.3

[RalfJung]

That makes the regression range: 59cec72...6689597

[RalfJung]

Maybe 76b6090? Cc @onur-ozkan

[matthiaskrgr]

Is this miri toolchain an x.py install'd one?

The only situation where I would ever get a

commit-hash: unknown
commit-date: unknown

is when I x.py install something as a toolchain from a local branch and then try to get the --version of that .

[RalfJung]

Is this miri toolchain an x.py install'd one?

No, as I said: "via rustup-toolchain-install-master".

[matthiaskrgr]

👍 I did a quick bisect and its indeed #132772 ^^

[RalfJung]

So if we change nothing, the next nightly will also be like this.

Should we urgently revert #132772?

[jieyouxu]

I'll put up a revert for now, we can reland #132772.

[RalfJung]

You mean reland it later once we figured out the problem? Yes, sounds good.

[jieyouxu]

Yes