search index doesn't properly regenerate when using `--document-private-items` after a normal `cargo doc` run

[mrnossiom]

Hi 👋🏻,

Running the following produces a documentation where private items are unsearchable:
cargo clean && cargo doc && cargo doc --document-private-items

Whereas running cargo doc with the document-private-items flag directly produces a search index that includes private items. (cargo clean && cargo doc --document-private-items)

I cannot reproduce on a fresh minimal crate, but it is consistent when trying on https://github.com/tower-lsp-community/tower-lsp-server/.

While trying to reproduce the issue, I was curious and diffed the produced target/doc folders. Only search-index.js differs: the whole part about private items is not present in the normal then private-items run.

Meta

rustc --version --verbose:

rustc 1.82.0 (f6e511eec 2024-10-15)
binary: rustc
commit-hash: f6e511eec7342f59a25f7c0534f1dbea00d01b14
commit-date: 2024-10-15
host: x86_64-unknown-linux-gnu
release: 1.82.0
LLVM version: 19.1.1

→ also tested with rustc 1.85.0-nightly (dff3e7ccd 2024-11-26)

cc @GuillaumeGomez

[lolbinarycat]

link is broken

[lolbinarycat]

ok i've identified the issue.

basically, the search index ends up with two entries for the same crate.

this could be fixed by deduplicating the array, but this would cause more problems if there were actually multiple crates with the same name (which is possible, especially if you have multiple versions of the same crate in a dependency tree)

i think this would be better fixed by cargo.

[a4lg]

I encountered the same issue (and I independently reported as now closed #136802). I hope my additional information helps.

Also although not reported by @mrnossiom, it seems summaries on the search results are broken.