ICE building smallvec with coverage support (nightly-to-nightly regression)

[RalfJung]

Code

We tried building Miri with coverage support (-C instrument-coverage); see the CI logs here. This ICEs:

error: internal compiler error: compiler/rustc_middle/src/ty/normalize_erasing_regions.rs:168:90: Failed to normalize [Alias(Projection, AliasTy { args: [A/#0], def_id: DefId(0:367 ~ smallvec[4893]::Array::Item), .. })], maybe try to call `try_normalize_erasing_regions` instead


thread 'rustc' panicked at compiler/rustc_middle/src/ty/normalize_erasing_regions.rs:168:90:
Box<dyn Any>
stack backtrace:
   0:     0x7fc0b9ee2b6a - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::ha3bc4f00e9e2c979
   1:     0x7fc0ba6135e6 - core::fmt::write::h83f200e99fb4dad4
   2:     0x7fc0bb4f02d1 - std::io::Write::write_fmt::h311c6b13b707fec1
   3:     0x7fc0b9ee29c2 - std::sys::backtrace::BacktraceLock::print::h51611c7078774653
   4:     0x7fc0b9ee4f67 - std::panicking::default_hook::{{closure}}::h16f1b5953b2fb1b0
   5:     0x7fc0b9ee4d50 - std::panicking::default_hook::h131593e803d8b280
   6:     0x7fc0b9054f38 - std[e634297ddf6551c]::panicking::update_hook::<alloc[e9a3c14938b4a821]::boxed::Box<rustc_driver_impl[6279f07e99aa1d2f]::install_ice_hook::{closure#1}>>::{closure#0}
   7:     0x7fc0b9ee57b3 - std::panicking::rust_panic_with_hook::he5a9310ec54a4e64
   8:     0x7fc0b908dcc1 - std[e634297ddf6551c]::panicking::begin_panic::<rustc_errors[3190855cc9e4054c]::ExplicitBug>::{closure#0}
   9:     0x7fc0b9082ea6 - std[e634297ddf6551c]::sys::backtrace::__rust_end_short_backtrace::<std[e634297ddf6551c]::panicking::begin_panic<rustc_errors[3190855cc9e4054c]::ExplicitBug>::{closure#0}, !>
  10:     0x7fc0b907f9b9 - std[e634297ddf6551c]::panicking::begin_panic::<rustc_errors[3190855cc9e4054c]::ExplicitBug>
  11:     0x7fc0b9097c21 - <rustc_errors[3190855cc9e4054c]::diagnostic::BugAbort as rustc_errors[3190855cc9e4054c]::diagnostic::EmissionGuarantee>::emit_producing_guarantee
  12:     0x7fc0b966c173 - rustc_middle[30b20b3db7b50d0c]::util::bug::opt_span_bug_fmt::<rustc_span[a32104fbac3839e4]::span_encoding::Span>::{closure#0}
  13:     0x7fc0b965117a - rustc_middle[30b20b3db7b50d0c]::ty::context::tls::with_opt::<rustc_middle[30b20b3db7b50d0c]::util::bug::opt_span_bug_fmt<rustc_span[a32104fbac3839e4]::span_encoding::Span>::{closure#0}, !>::{closure#0}
  14:     0x7fc0b965100b - rustc_middle[30b20b3db7b50d0c]::ty::context::tls::with_context_opt::<rustc_middle[30b20b3db7b50d0c]::ty::context::tls::with_opt<rustc_middle[30b20b3db7b50d0c]::util::bug::opt_span_bug_fmt<rustc_span[a32104fbac3839e4]::span_encoding::Span>::{closure#0}, !>::{closure#0}, !>
  15:     0x7fc0b7908240 - rustc_middle[30b20b3db7b50d0c]::util::bug::bug_fmt
  16:     0x7fc0bac3396f - <rustc_middle[30b20b3db7b50d0c]::ty::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder as rustc_type_ir[c3559ba0b6d341e0]::fold::TypeFolder<rustc_middle[30b20b3db7b50d0c]::ty::context::TyCtxt>>::fold_ty
  17:     0x7fc0bb8900f6 - <&rustc_middle[30b20b3db7b50d0c]::ty::list::RawList<(), rustc_middle[30b20b3db7b50d0c]::ty::generic_args::GenericArg> as rustc_type_ir[c3559ba0b6d341e0]::fold::TypeFoldable<rustc_middle[30b20b3db7b50d0c]::ty::context::TyCtxt>>::try_fold_with::<rustc_middle[30b20b3db7b50d0c]::ty::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder>
  18:     0x7fc0b9baece5 - <rustc_middle[30b20b3db7b50d0c]::ty::context::TyCtxt>::normalize_erasing_regions::<rustc_type_ir[c3559ba0b6d341e0]::predicate::TraitRef<rustc_middle[30b20b3db7b50d0c]::ty::context::TyCtxt>>
  19:     0x7fc0b9bbba15 - <rustc_symbol_mangling[91c82856261a6258]::v0::SymbolMangler as rustc_middle[30b20b3db7b50d0c]::ty::print::Printer>::print_impl_path
  20:     0x7fc0b9bbaf59 - <rustc_symbol_mangling[91c82856261a6258]::v0::SymbolMangler as rustc_middle[30b20b3db7b50d0c]::ty::print::Printer>::print_def_path
  21:     0x7fc0b9bbb645 - <rustc_symbol_mangling[91c82856261a6258]::v0::SymbolMangler as rustc_middle[30b20b3db7b50d0c]::ty::print::Printer>::print_def_path
  22:     0x7fc0b9bbaa70 - rustc_symbol_mangling[91c82856261a6258]::v0::mangle
  23:     0x7fc0baf2862d - rustc_symbol_mangling[91c82856261a6258]::symbol_name_provider
  24:     0x7fc0baf270aa - rustc_query_impl[7c1ec1df0b776991]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[7c1ec1df0b776991]::query_impl::symbol_name::dynamic_query::{closure#2}::{closure#0}, rustc_middle[30b20b3db7b50d0c]::query::erase::Erased<[u8; 16usize]>>
  25:     0x7fc0baf26037 - rustc_query_system[644fd28009304888]::query::plumbing::try_execute_query::<rustc_query_impl[7c1ec1df0b776991]::DynamicConfig<rustc_query_system[644fd28009304888]::query::caches::DefaultCache<rustc_middle[30b20b3db7b50d0c]::ty::instance::Instance, rustc_middle[30b20b3db7b50d0c]::query::erase::Erased<[u8; 16usize]>>, false, false, false>, rustc_query_impl[7c1ec1df0b776991]::plumbing::QueryCtxt, false>
  26:     0x7fc0baf25ca2 - rustc_query_impl[7c1ec1df0b776991]::query_impl::symbol_name::get_query_non_incr::__rust_end_short_backtrace
  27:     0x7fc0bb12d98c - rustc_middle[30b20b3db7b50d0c]::query::plumbing::query_get_at::<rustc_query_system[644fd28009304888]::query::caches::DefaultCache<rustc_middle[30b20b3db7b50d0c]::ty::instance::Instance, rustc_middle[30b20b3db7b50d0c]::query::erase::Erased<[u8; 16usize]>>>
  28:     0x7fc0b8edc815 - rustc_codegen_llvm[b43b4fa4a9a79a5]::coverageinfo::mapgen::finalize
  29:     0x7fc0bb55cbd8 - rustc_codegen_llvm[b43b4fa4a9a79a5]::base::compile_codegen_unit::module_codegen
  30:     0x7fc0bb5506c8 - <rustc_codegen_llvm[b43b4fa4a9a79a5]::LlvmCodegenBackend as rustc_codegen_ssa[4631c4d6409aa8ac]::traits::backend::ExtraBackendMethods>::compile_codegen_unit
  31:     0x7fc0bb54caec - <rustc_codegen_llvm[b43b4fa4a9a79a5]::LlvmCodegenBackend as rustc_codegen_ssa[4631c4d6409aa8ac]::traits::backend::CodegenBackend>::codegen_crate
  32:     0x7fc0bb5f96a4 - <rustc_interface[412687b4afbff3a1]::queries::Linker>::codegen_and_build_linker
  33:     0x7fc0bb5ef012 - rustc_interface[412687b4afbff3a1]::passes::create_and_enter_global_ctxt::<core[8295d53c64f43325]::option::Option<rustc_interface[412687b4afbff3a1]::queries::Linker>, rustc_driver_impl[6279f07e99aa1d2f]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}
  34:     0x7fc0bb5295a4 - rustc_interface[412687b4afbff3a1]::interface::run_compiler::<(), rustc_driver_impl[6279f07e99aa1d2f]::run_compiler::{closure#0}>::{closure#1}
  35:     0x7fc0bb4026c7 - std[e634297ddf6551c]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[412687b4afbff3a1]::util::run_in_thread_with_globals<rustc_interface[412687b4afbff3a1]::util::run_in_thread_pool_with_globals<rustc_interface[412687b4afbff3a1]::interface::run_compiler<(), rustc_driver_impl[6279f07e99aa1d2f]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>
  36:     0x7fc0bb402b64 - <<std[e634297ddf6551c]::thread::Builder>::spawn_unchecked_<rustc_interface[412687b4afbff3a1]::util::run_in_thread_with_globals<rustc_interface[412687b4afbff3a1]::util::run_in_thread_pool_with_globals<rustc_interface[412687b4afbff3a1]::interface::run_compiler<(), rustc_driver_impl[6279f07e99aa1d2f]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[8295d53c64f43325]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  37:     0x7fc0bb404141 - std::sys::pal::unix::thread::Thread::new::thread_start::h8f1e830f9e043eda
  38:     0x7fc0b569ca94 - <unknown>
  39:     0x7fc0b5729c3c - <unknown>
  40:                0x0 - <unknown>

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: please make sure that you have updated to the latest nightly

note: please attach the file at `/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/smallvec-1.13.2/rustc-ice-2025-01-08T04_48_32-3573.txt` to your bug report

note: compiler flags: --crate-type lib -C opt-level=2 -C embed-bitcode=no -C debuginfo=2 -C debug-assertions=on -C link-args=-Wl,-rpath,/home/runner/.rustup/toolchains/miri/lib/rustlib/x86_64-unknown-linux-gnu/lib -Z unstable-options -C instrument-coverage

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [symbol_name] computing the symbol for `<impl at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/smallvec-1.13.2/src/lib.rs:1864:1: 1864:48>::as_ref`
end of query stack
error: could not compile `smallvec` (lib)

Regression range: ad211ce...0707499

[RalfJung]

So this must be something in #135218.

Cc @compiler-errors , #134745 seems like the most likely culprit?

Could also be #135149 or #133810 though, Cc @lcnr.

[lcnr]

pretty sure it's #135149. This is an error when normalizing during symbol mangling and that PR changed the used env there

[compiler-errors]

@RalfJung, what's the best way to reproduce this in isolation? I'd rather not run the whole CI job 😄

[compiler-errors]

nvm I can repro it by just building smallvec@1.13.2 with coverage

[RalfJung]

I was about so suggest building Miri with coverage but this is better :)

[cernec1999]

It looks like you all have it covered, but just throwing in my error message just in case you need more info. It occurred during my CI coverage instrumentation step. Minimally reproducible example can be created using petgraph as well.

thread 'rustc' panicked at compiler/rustc_middle/src/ty/normalize_erasing_regions.rs:168:90:
Box<dyn Any>
stack backtrace:
   0:     0x7f1c35ae3a7a - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::hc48a3003e72a1fb5
   1:     0x7f1c36213126 - core::fmt::write::h244b471aa97315bd
   2:     0x7f1c37122211 - std::io::Write::write_fmt::h63cacec38f2c7922
   3:     0x7f1c35ae38d2 - std::sys::backtrace::BacktraceLock::print::h8e88b30882062ce8
   4:     0x7f1c35ae5e77 - std::panicking::default_hook::{{closure}}::he2b2f35b61e5b6b4
   5:     0x7f1c35ae5c60 - std::panicking::default_hook::h2b9fc43053d2ca15
   6:     0x7f1c34c568a8 - std[c08ade969ea4a026]::panicking::update_hook::<alloc[ecf666bc700c7d64]::boxed::Box<rustc_driver_impl[7ccddf7307cff907]::install_ice_hook::{closure#1}>>::{closure#0}
   7:     0x7f1c35ae66c3 - std::panicking::rust_panic_with_hook::h1126dbe971a7f919
   8:     0x7f1c34c8ecc1 - std[c08ade969ea4a026]::panicking::begin_panic::<rustc_errors[1eaa06d4a73dafc5]::ExplicitBug>::{closure#0}
   9:     0x7f1c34c83ea6 - std[c08ade969ea4a026]::sys::backtrace::__rust_end_short_backtrace::<std[c08ade969ea4a026]::panicking::begin_panic<rustc_errors[1eaa06d4a73dafc5]::ExplicitBug>::{closure#0}, !>
  10:     0x7f1c34c83c63 - std[c08ade969ea4a026]::panicking::begin_panic::<rustc_errors[1eaa06d4a73dafc5]::ExplicitBug>
  11:     0x7f1c34c98c21 - <rustc_errors[1eaa06d4a73dafc5]::diagnostic::BugAbort as rustc_errors[1eaa06d4a73dafc5]::diagnostic::EmissionGuarantee>::emit_producing_guarantee
  12:     0x7f1c3526db03 - rustc_middle[bc4ae9fc2bf4235a]::util::bug::opt_span_bug_fmt::<rustc_span[cfc513d191a8d813]::span_encoding::Span>::{closure#0}
  13:     0x7f1c35252b1a - rustc_middle[bc4ae9fc2bf4235a]::ty::context::tls::with_opt::<rustc_middle[bc4ae9fc2bf4235a]::util::bug::opt_span_bug_fmt<rustc_span[cfc513d191a8d813]::span_encoding::Span>::{closure#0}, !>::{closure#0}
  14:     0x7f1c352529ab - rustc_middle[bc4ae9fc2bf4235a]::ty::context::tls::with_context_opt::<rustc_middle[bc4ae9fc2bf4235a]::ty::context::tls::with_opt<rustc_middle[bc4ae9fc2bf4235a]::util::bug::opt_span_bug_fmt<rustc_span[cfc513d191a8d813]::span_encoding::Span>::{closure#0}, !>::{closure#0}, !>
  15:     0x7f1c333d3d20 - rustc_middle[bc4ae9fc2bf4235a]::util::bug::bug_fmt
  16:     0x7f1c3680f12f - <rustc_middle[bc4ae9fc2bf4235a]::ty::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder as rustc_type_ir[72683c14ceefff53]::fold::TypeFolder<rustc_middle[bc4ae9fc2bf4235a]::ty::context::TyCtxt>>::fold_ty
  17:     0x7f1c3748b3c5 - <&rustc_middle[bc4ae9fc2bf4235a]::ty::list::RawList<(), rustc_middle[bc4ae9fc2bf4235a]::ty::generic_args::GenericArg> as rustc_type_ir[72683c14ceefff53]::fold::TypeFoldable<rustc_middle[bc4ae9fc2bf4235a]::ty::context::TyCtxt>>::try_fold_with::<rustc_middle[bc4ae9fc2bf4235a]::ty::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder>
  18:     0x7f1c357afe45 - <rustc_middle[bc4ae9fc2bf4235a]::ty::context::TyCtxt>::normalize_erasing_regions::<rustc_type_ir[72683c14ceefff53]::predicate::TraitRef<rustc_middle[bc4ae9fc2bf4235a]::ty::context::TyCtxt>>
  19:     0x7f1c357bcb75 - <rustc_symbol_mangling[403ef980f7f2d81]::v0::SymbolMangler as rustc_middle[bc4ae9fc2bf4235a]::ty::print::Printer>::print_impl_path
  20:     0x7f1c357bc0b9 - <rustc_symbol_mangling[403ef980f7f2d81]::v0::SymbolMangler as rustc_middle[bc4ae9fc2bf4235a]::ty::print::Printer>::print_def_path
  21:     0x7f1c357bc7a5 - <rustc_symbol_mangling[403ef980f7f2d81]::v0::SymbolMangler as rustc_middle[bc4ae9fc2bf4235a]::ty::print::Printer>::print_def_path
  22:     0x7f1c357bbbd0 - rustc_symbol_mangling[403ef980f7f2d81]::v0::mangle
  23:     0x7f1c36d226ae - rustc_symbol_mangling[403ef980f7f2d81]::symbol_name_provider
  24:     0x7f1c36d2112a - rustc_query_impl[9bbd9b92042adb73]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[9bbd9b92042adb73]::query_impl::symbol_name::dynamic_query::{closure#2}::{closure#0}, rustc_middle[bc4ae9fc2bf4235a]::query::erase::Erased<[u8; 16usize]>>
  25:     0x7f1c36d200b7 - rustc_query_system[7c1448542a492b7f]::query::plumbing::try_execute_query::<rustc_query_impl[9bbd9b92042adb73]::DynamicConfig<rustc_query_system[7c1448542a492b7f]::query::caches::DefaultCache<rustc_middle[bc4ae9fc2bf4235a]::ty::instance::Instance, rustc_middle[bc4ae9fc2bf4235a]::query::erase::Erased<[u8; 16usize]>>, false, false, false>, rustc_query_impl[9bbd9b92042adb73]::plumbing::QueryCtxt, false>
  26:     0x7f1c36d1fd22 - rustc_query_impl[9bbd9b92042adb73]::query_impl::symbol_name::get_query_non_incr::__rust_end_short_backtrace
  27:     0x7f1c36da968c - rustc_middle[bc4ae9fc2bf4235a]::query::plumbing::query_get_at::<rustc_query_system[7c1448542a492b7f]::query::caches::DefaultCache<rustc_middle[bc4ae9fc2bf4235a]::ty::instance::Instance, rustc_middle[bc4ae9fc2bf4235a]::query::erase::Erased<[u8; 16usize]>>>
  28:     0x7f1c34add915 - rustc_codegen_llvm[cf0745383bf2fa70]::coverageinfo::mapgen::finalize
  29:     0x7f1c36d3e458 - rustc_codegen_llvm[cf0745383bf2fa70]::base::compile_codegen_unit::module_codegen
  30:     0x7f1c371e9dc8 - <rustc_codegen_llvm[cf0745383bf2fa70]::LlvmCodegenBackend as rustc_codegen_ssa[8aad7319a10dd306]::traits::backend::ExtraBackendMethods>::compile_codegen_unit
  31:     0x7f1c371e612c - <rustc_codegen_llvm[cf0745383bf2fa70]::LlvmCodegenBackend as rustc_codegen_ssa[8aad7319a10dd306]::traits::backend::CodegenBackend>::codegen_crate
  32:     0x7f1c371ee124 - <rustc_interface[9ea0a400d5371a28]::queries::Linker>::codegen_and_build_linker
  33:     0x7f1c37158892 - rustc_interface[9ea0a400d5371a28]::passes::create_and_enter_global_ctxt::<core[6b5cbebef9c0da3b]::option::Option<rustc_interface[9ea0a400d5371a28]::queries::Linker>, rustc_driver_impl[7ccddf7307cff907]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}
  34:     0x7f1c371cba64 - rustc_interface[9ea0a400d5371a28]::interface::run_compiler::<(), rustc_driver_impl[7ccddf7307cff907]::run_compiler::{closure#0}>::{closure#1}
  35:     0x7f1c3702d651 - std[c08ade969ea4a026]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[9ea0a400d5371a28]::util::run_in_thread_with_globals<rustc_interface[9ea0a400d5371a28]::util::run_in_thread_pool_with_globals<rustc_interface[9ea0a400d5371a28]::interface::run_compiler<(), rustc_driver_impl[7ccddf7307cff907]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>
  36:     0x7f1c3702db08 - <<std[c08ade969ea4a026]::thread::Builder>::spawn_unchecked_<rustc_interface[9ea0a400d5371a28]::util::run_in_thread_with_globals<rustc_interface[9ea0a400d5371a28]::util::run_in_thread_pool_with_globals<rustc_interface[9ea0a400d5371a28]::interface::run_compiler<(), rustc_driver_impl[7ccddf7307cff907]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[6b5cbebef9c0da3b]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  37:     0x7f1c3702f0af - std::sys::pal::unix::thread::Thread::new::thread_start::h2f2b51e924b57f78
  38:     0x7f1c3129ca94 - <unknown>
  39:     0x7f1c31329c3c - <unknown>
  40:                0x0 - <unknown>

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: please make sure that you have updated to the latest nightly

note: please attach the file at `/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/petgraph-0.7.1/rustc-ice-2025-01-09T03_34_12-2395.txt` to your bug report

note: compiler flags: --crate-type lib -C embed-bitcode=no -C debuginfo=2 -C instrument-coverage

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [symbol_name] computing the symbol for `visit::traversal::<impl at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/petgraph-0.7.1/src/visit/traversal.rs:498:1: 500:34>::walk_next`
end of query stack
error: could not compile `petgraph` (lib)