regression: type annotations needed

[BoxyUwU]

• https://crater-reports.s3.amazonaws.com/beta-1.85-1/beta-2025-01-12/gh/LuisDuarte1.diesel-d1/log.txt

[INFO] [stdout] error[E0283]: type annotations needed
[INFO] [stdout]   --> src/bind_collector.rs:40:24
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let metadata = D1Backend::metadata(metadata_lookup);
[INFO] [stdout]    |                        ^^^^^^^^^ cannot infer type for type parameter `ST` declared on the trait `HasSqlType`
[INFO] [stdout]    |
[INFO] [stdout]    = note: cannot satisfy `D1Backend: HasSqlType<_>`

[compiler-errors]

This seems to have regressed in 604d669 #132325

cc @lcnr, though I'll check if we mentioend this as a breakage in that pr or if crater missed it or something

[theemathas]

If I'm reading that PR's thread correctly, it seems that crater had some issue that made it not properly test some crates, but then the PR got merged anyway for some reason.

[compiler-errors]

Yep, there was a period of time when we were getting a lot of "unknown" crater results. That was fixed sometime later, and we didn't realize that it caused a bunch of false negatives until after.

I think this is probably worth still breaking, though perhaps lcnr can characterize in a more clear way why this broke and why it's consistent to break it.

[lcnr]

though I'll check if we mentioend this as a breakage in that pr or if crater missed it or something

the crate was published after the crater run on dec. 11

[apiraino]

Note: if we are going to accept this breakage, #132325 will need relnotes

[lcnr]

I've opened a fix in LuisDuarte1/diesel-d1#2. I consider this to very much be intended breakage.

cc @rust-lang/types I intend to close this regression as accepted.

[lcnr]

Note: if we are going to accept this breakage, #132325 will need relnotes

does it? it was FCP'd so it has been picked up for relnotes regardless 🤔 #134309

[apiraino]

does it? it was FCP'd so it has been picked up for relnotes regardless 🤔 #134309

Ah! I missed that #134309 was already so, thanks for pointing me there 👍