Skip to content

compiletest: investigate if compare-mode nits are still relevant #136513

Open
@jieyouxu

Description

@jieyouxu

also, I don't know if this is exactly relevant to this particular PR, but during my experimentation: When I created an empty augmented-assignments.nll.stderr file, I expected to see a diff that just showed all plusses. (I.e., a diff against an empty file)

But instead it seems like if the revision file is empty, then it falls back on the base file augmented-assignments.stderr, in this particular case...

  • (From skimming the PR, I'm not even clear on how we are observing such a semantics... but nonetheless, it is what I am seeing.)

(I don't know whether other people think that fall back behavior for empty files is more intutive... it wasn't intuitive for me, since I'm the kind of person who will just do touch augmented-assignments.nll.stderr and then run the tool to see what the content is that I need to add.)

Originally posted by @pnkfelix in #49293 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-compiletest-compare-modesArea: compiletest compare-modesC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions