Skip to content

Add one more "late metadata"/"digest" file to rlib archives #138243

@petrochenkov

Description

@petrochenkov

The file should contain data about:

  • Native libraries bundled into the rlib, to avoid looking up native libraries during the regular "early" metadata construction, when it's unnecessary and cannot be done fully correctly (native_libs: More consistent native library search between rustc and linker #138170)
  • Object files bundled into the rlib, to support link time cfg on native libraries bundled as object files
  • Rust object files in the rlib to avoid hacks like looks_like_rust_object_file during LTO

Unlike regular metadata which is constructed early, this additional digest will be constructed and added to the archive in the very end, when all other members of the rlib archive are already added.
It is also going to be read only when rustc is going to link the rlib into something, not earlier.

The data could potentially use some text format like json, but it would probably be simpler to just use the same format as the regular metadata uses.
The implementation can also mirror what is done for regular metadata, in a simplified form.

Me and @belovdv wanted to do this when implementing +bundle,+whole-archive (#113301) and packed_bundled_libs (#108081), as a more principle solution, but ended up with just some workarounds instead, and never returned to this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-linkageArea: linking into static, shared libraries and binariesC-enhancementCategory: An issue proposing an enhancement or a PR with one.E-help-wantedCall for participation: Help is requested to fix this issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions