Skip to content

compiletest "not found errors" output is badly formatted #140940

Open
@RalfJung

Description

@RalfJung

When compiletest encounters "not found errors", its output now looks like this:

--- not found errors (from test file) ---
ERRORline  11: it is undefined behavior to use this value
NOTEline  11: reference to mutable memory
---

That looks glitched out, with the lack of a space before "line". I think the line number should probably come first anyway, before the diagnostic kind.

I think this is a regression, this used to look just fine.

The formatting seems to happen here:

format!("{: <10}line {: >3}: {}", self.kind, self.line_num_str(), self.msg.cyan())

Cc @petrochenkov

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions