make runtime library loading safer

[emberian]

We currently have an interface for runtime library loading, using the dynamic linker, but it has the problem that it interacts poorly with name mangling and is entirely unsafe. Figure out how to make it type-safe, and preferably memory-safe too.

[emberian]

I believe @Kimundi had some ideas here.

[Kimundi]

Dynamic loading of non-Rust libraries can probably not be made safe in general because of missing type metadata, so I'll only talk about dynamically loaded Rust crates.

Additionally, dynamically loaded crates and dynamically compiled crates (like produced by a jit compiler) both only start to exist at runtime and can get cleaned up, so I see this as an issue for any kind of native code with non-'static lifetimes.

Requirements

In an ideal world, you would have a safe way to dynamically load a library, use its symbols, and then afterwards unload the library again, likely implemented with some kind of RAAI scheme.

The interface should be typesafe, which implies that communication between host executable and dynamic library can only happen through types known to both.

And if should be memory safe, which implies that no dependencies on dynamically loaded code should escape the lifetime of the dynamic library.

However, there are three problems that need to be solved for this to happen:

• Typechecking
  This one is comparatively easy, but probably needs to have a intrinsic added. It could be implemented by having a generic function fn load_symbol<T>(path: &str), used like load_symbol::<fn(uint, Bar) -> Baz>("a::b::c::bar_adder").
  It would create a globally unique identifier for the type it got instantiated with, read the metadata of the dynamic library, try to resolve the given path in it, and then confirms that it points at an item with the same unique type identifier. This might be implementable with the current type_id intrinsic, but you might want to have a intrinsic that gives a few more informations.

• Don't let function pointers escape
  A problem in the Rust language right now is that function pointers are always implicitly assumed to be equivalent to something like &'static code, that is they are copyable and can outlive any scope. This is true for direct function types like fn(Foo) -> Bar, as well for types that implicitly contain them, like &Trait or |Foo| -> Bar, where the function pointers are hidden in vtables or similar.
  If all code is valid for the duration of the process, this is not a problem and makes things easier, but with dynamically loaded libraries you have a problem. Say you have the symbol fn() -> Box<Trait>. It would allow you to get a new owned trait object with a vtable that becomes invalid as soon as the dynamic library gets unloaded. Bad!
  Even if the function pointer itself gets a lifetime, you could have a type like fn () -> fn() -> fn() -> (), where each return value is a new independent value that also needs to be lifetime restricted. So you can't just look at the type itself, but also at all types deriveable by function calls or similar.

• Not letting 'static lifetimes escape
  This is similar to the problem above: Say you have a symbol fn() -> &'static Foo. Normally you could assume from such a signature that there is a constant of type Foo that you are returning a reference too, which you can continue using afterwards without any lifetime restrictions.

  However, in the case of a dynamic library such a type would lie: The lifetime of the reference is not 'static, its actually a 'a that is the intersection of 'static and the lifetime of the crate it got loaded from.

Possible solutions:

1. Don't change the language, and always leak the loaded dynamic code so that lifetimes never end.
   This is a valid approach, but ugly because it leaks memory, which restricts the possible use cases it applies too. For example, a simple plugin system might not have a problem with this, as the number if plugins is limited, but a system that repeatedly jits new code could get into trouble fast with this approach.

2. Don't change the language, but restrict the set of possible loadable symbols.
   This would involve the symbol loader figuring out if a given symbol can lead to lifetime-leaking function pointers or &'statics, and prohibit those symbols from being loaded, and otherwise only expose the actual function pointer through a wrapper struct that ensures a lifetime dependency on it.
   This might be enough for many cases, but probably would have to block language features like type erasure in general to be made sound.

3. Extend the typesystem with a optional annotation to "taint" any 'static lifetime in a type graph with a smaller lifetime 'a. I'm not sure exactly how and if that could work, but I imagine it being similar to the build-in traits. The dynamic code loader could then use that annotation to limit the graph starting with the symbol function pointer itself.
   This approach has probably the most promise, but its also the hardest to implement as it involves language changes.
   Imaginary example syntax:

   fn load_symbol<'a, T>(&'a self) -> T<crate: 'a>;
   let x = c.load_symbol::<fn() -> fn() -> ()>();
   let f: (fn() -> fn() -> ())<crate: 'a> = x; // OK
   let g: (fn() -> ())<crate: 'a> = x(); // OK
   let h: fn() -> () = x(); // ERROR!
   

[PatrLind]

How about keeping track of all things related to the library and not allow unload until it is safe to do so?

[thestinger]

It's fundamentally impossible for runtime library loading to be safe. It can be made safer via verification of the metadata in the crate, but loading a library from a path dynamically will always be unsafe. It's not sane to trust files at arbitrary files on the filesystem and there is no race-free way to do something like verifying that the library is controlled by root or the current user.

A library runs arbitrary initialization code upon loading, and nothing prevents the code from having invalid metadata or simply being memory unsafe. It would be trivial to bypass safety restrictions by outputting arbitrary code in a plugin and running it.

[emberian]

Yes, of course the actual loading would be unsafe for obvious reasons, but
it could still be type safe and memory safe after it's loaded, given an
assumption that the library is "trusted", even if that's only verified by a
hash or signature. At some point you need to give up on absolute security
if you want the flexibility afforded by runtime reloading, and assume the
system is hostile.

On Tue, Oct 21, 2014 at 4:11 PM, Daniel Micay notifications@github.com
wrote:

It's fundamentally impossible for runtime library loading to be safe.
It can be made safer via verification of the metadata in the crate, but
loading a library from a path dynamically will always be unsafe. It's not
sane to trust files at arbitrary files on the filesystem and there is no
race-free way to do something like verifying that the library is controlled
by root or the current user. A library runs arbitrary initialization code
upon loading, and nothing prevents the code from having invalid metadata or
simply being memory unsafe. It would be trivial to bypass safety
restrictions by outputting arbitrary code in a plugin and running it.

—
Reply to this email directly or view it on GitHub
#15040 (comment).

http://octayn.net/

[thestinger]

It can only be verified by a hash / signature if you load the entire thing into memory first and then somehow load it from there without touching the file again. It's never going to be appropriate to remove the unsafe marker from the API because running arbitrary code from an arbitrary path is fundamentally memory unsafe.