Skip to content

Emit helpful note messages only once #24690

Closed
@bluss

Description

@bluss

Example: Adding #![deny(lint_name)] to a crate will point out the location of this line for every time the lint fires (note: lint level defined here). This should be listed only once. It should be reasonably easy to deduplicate these based upon equal span and message.

src/adaptors.rs:84:5: 87:6 warning: missing documentation for a method
src/adaptors.rs:84     pub fn new(iter: I, map: fn(I::Item) -> B) -> Self
src/adaptors.rs:85     {
src/adaptors.rs:86         FnMap{iter: iter, map: map}
src/adaptors.rs:87     }
src/lib.rs:1:9: 1:21 note: lint level defined here
src/lib.rs:1 #![warn(missing_docs)]
                     ^~~~~~~~~~~~
src/islice.rs:30:5: 37:6 warning: missing documentation for a method
src/islice.rs:30     pub fn new<R: GenericRange>(iter: I, range: R) -> Self
src/islice.rs:31     {
src/islice.rs:32         ISlice {
src/islice.rs:33             start: range.start().unwrap_or(0),
src/islice.rs:34             end: range.end().unwrap_or(::std::usize::MAX),
src/islice.rs:35             iter: iter,
                 ...
src/lib.rs:1:9: 1:21 note: lint level defined here
src/lib.rs:1 #![warn(missing_docs)]
                     ^~~~~~~~~~~~
src/misc.rs:15:5: 15:17 warning: missing documentation for an associated type
src/misc.rs:15     type Result;
                   ^~~~~~~~~~~~
src/lib.rs:1:9: 1:21 note: lint level defined here
src/lib.rs:1 #![warn(missing_docs)]

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lints

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions