Skip to content

pretty test should not specify --crate-type=lib when typechecking #27567

Closed
@TimNN

Description

@TimNN

Since the early days of pretty tests (77be30f) they were compiled as libraries so that they did not require a main function. By now they also run on all the run pass test, which all have a main and there is (or soon will be) at least one run pass test which requires to be compiled as a binary (see #27565).

As discussed shortly on irc (starting here), the best solution seems to be to remove that flag and only add it to those tests which require it.

I'll try to tackle this and get a pull request up soon.

cc @nrc

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions